Handle limit offset and sorting in files search #26198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
icewind1991
commented
Mar 18, 2021
•
icewind1991
commented
- Use Node search api directly from files' search provider, skipping a few deprecated layers
- Unify handling of node search methods by transforming all search methods into "new" search queries
- Handle limit, offset and order in node search api (in a somewhat suboptimal way)
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-search-node
branch
from
2fb2d02 to
c25f7d7
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-search-node
branch
from
c25f7d7 to
b38618c
Compare
icewind1991
changed the title
icewind1991
added
3. to review
icewind1991
requested review from
ChristophWurst,
skjnldsv,
rullzer and
MorrisJobke
and removed request for
ChristophWurst
skjnldsv
approved these changes
Mar 22, 2021
|
Thanks for this @icewind1991 ! |
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
|
The backport to stable19 failed. Please do this backport manually. |
This was referenced Mar 23, 2021
icewind1991
added a commit
that referenced
this pull request
Apr 1, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
added a commit
that referenced
this pull request
Apr 1, 2021
remove leftover debug @NoCSRFRequired introduced with #26198
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Apr 1, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Apr 1, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
added a commit
that referenced
this pull request
Apr 1, 2021
[stable21] remove leftover debug @NoCSRFRequired introduced with #26198
MorrisJobke
added a commit
that referenced
this pull request
Apr 1, 2021
[stable20] remove leftover debug @NoCSRFRequired introduced with #26198
This was referenced Apr 1, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.