Use constant for supported formats #26323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
rullzer
reviewed
Mar 29, 2021
| @@ -57,10 +57,20 @@ | |||
| * @package OCA\Encryption\Crypto | |||
| */ | |||
| class Crypt { | |||
| public const SUPPORTED_CIPHERS_AND_KEY_SIZE = [ | |||
There was a problem hiding this comment.
why does their visibility change all of a sudden?
There was a problem hiding this comment.
DEFAULT_CIPHER and LEGACY_CIPHER are also public, so IMHO it makes sense to have the same visibility for all available ciphers.
There was a problem hiding this comment.
@rullzer should I revert this change?
There was a problem hiding this comment.
#26383 depends on this
LukasReschke
approved these changes
Apr 26, 2021
|
asking @nextcloud/encryption for a second review 😃 |
blizzz
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported since PHP 5.6.