-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use findBinaryPath for previews #26531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0WI
changed the title
Refactor preview binary execution to use findBinaryPath
Use findBinaryPath for previews
Apr 12, 2021
J0WI
force-pushed
the
refactor-preview-exec
branch
5 times, most recently
from
April 13, 2021 00:33
d88f879
to
fd7b742
Compare
Fine by me to remove avconv right away. |
J0WI
force-pushed
the
refactor-preview-exec
branch
from
July 18, 2021 22:27
fd7b742
to
58e97b1
Compare
nickvergessen
approved these changes
Aug 20, 2021
Merged
skjnldsv
approved these changes
Oct 22, 2021
Please rebase :) |
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
J0WI
force-pushed
the
refactor-preview-exec
branch
from
October 23, 2021 21:16
58e97b1
to
047cab8
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findBinaryPath uses cache:
server/lib/private/legacy/OC_Helper.php
Lines 460 to 464 in 4be2e16
I think avconv can be removed completely in near future, the fork is no longer maintained: https://lists.libav.org/pipermail/libav-devel/2020-April/086589.html