Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use findBinaryPath for previews #26531

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Apr 12, 2021

findBinaryPath uses cache:

public static function findBinaryPath($program) {
$memcache = \OC::$server->getMemCacheFactory()->createDistributed('findBinaryPath');
if ($memcache->hasKey($program)) {
return $memcache->get($program);
}

I think avconv can be removed completely in near future, the fork is no longer maintained: https://lists.libav.org/pipermail/libav-devel/2020-April/086589.html

@J0WI J0WI changed the title Refactor preview binary execution to use findBinaryPath Use findBinaryPath for previews Apr 12, 2021
@J0WI J0WI force-pushed the refactor-preview-exec branch 5 times, most recently from d88f879 to fd7b742 Compare April 13, 2021 00:33
@J0WI J0WI marked this pull request as ready for review April 20, 2021 13:10
@J0WI J0WI added the 3. to review Waiting for reviews label Apr 20, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jun 18, 2021
@kesselb
Copy link
Contributor

kesselb commented Jul 6, 2021

Fine by me to remove avconv right away.

@skjnldsv
Copy link
Member

Please rebase :)

@skjnldsv skjnldsv added the bug label Oct 22, 2021
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 8ea91b4 into nextcloud:master Oct 25, 2021
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 25, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
25 tasks
@J0WI J0WI deleted the refactor-preview-exec branch October 28, 2021 15:32
mejo- added a commit that referenced this pull request Feb 2, 2022
`new \imagick` returns an object, but we need the image blob (binary
string) from this object.

This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.

Fixes: #29956

Signed-off-by: Jonas Meurer <jonas@freesources.org>
mejo- added a commit that referenced this pull request Feb 2, 2022
`new \imagick` returns an object, but we need the image blob (binary
string) from this object.

This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.

Fixes: #29956

Signed-off-by: Jonas Meurer <jonas@freesources.org>
mejo- added a commit that referenced this pull request Feb 2, 2022
`new \imagick()` returns an object, but we need the image blob (binary
string) from this object.

This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.

Fixes: #29956

Signed-off-by: Jonas Meurer <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants