Do not connect to database before creating it #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @harry-7 and @MorrisJobke to be potential reviewers. |
|
👍 This solves #2661 Now I can use root password and DB + user is created. Thanks for the fix, I spent 6 hours on this yesterday thinking I was doing something wrong... |
|
Btw, this should be 11.0.1 IMHO as it worked on 10.0.2 and broke in 11, so this is a bugfix for 11.0.1, right? |
|
This goes into 12 and is then backported for 11.0.1 (hence the backport-request label) |
icewind1991
approved these changes
Dec 14, 2016
|
@nickvergessen Missed that ;) |
rullzer
deleted the
issue-2646-dont-connet-to-database-before-creating-it
branch
enoch85
pushed a commit
that referenced
this pull request
Dec 15, 2016
Backport of #2670 to stable 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2646
broken by https://github.com/nextcloud/server/pull/381/files#diff-93de257bbddb07009f7fd887790d0b5cL96 through @icewind1991
Please test @enoch85 @lightonflux @ greyltc