Fix federated scope not shown when public addressbook upload is disabled

[danxuliu]

Follow up to #26243

Besides a small change in a test, when the public address book is disabled now it is possible to select the Federated scope for the profile attributes, as the address books can still be exchanged between trusted servers. Besides that the Federated option is now hidden when the Federation app is disabled

Please note that this might need to be adjusted in the mobile apps as well. Should the property in the capabilities be renamed too? The capability AccountPropertyScopesFederationEnabled was split in AccountPropertyScopesFederatedEnabled and AccountPropertyScopesPublishedEnabled.

How to test (scenario 1)

• Log in as an admin
• Open the settings
• Open the Sharing section under Administration
• Disable Allow users to publish their data to a global and public address book
• Open the Personal info section
• Show the visibility menu on any of the elements, like Phone number

Result with this pull request

The Federated option is still available, although the Published option is not

Result without this pull request

Neither the Federated nor the Published options are available

How to test (scenario 2)

• Log in as an admin
• Disable the Federation app
• Open the settings
• Open the Personal info section
• Show the visibility menu on any of the elements, like Phone number

Result with this pull request

The Federated option is no longer available

Result without this pull request

The Federated option is still available

Additional context

It can be checked that even if uploads to the lookup server are disabled the address book is still exchanged between trusted servers in the following way:

• Start server A
• Create user A in server A
• Start server B
• Create user B in server B
• In server A, open the (Administration) Sharing section
• Disable Allow users to publish their data to a global and public address book
• In server B, open the (Administration) Sharing section
• Disable Allow users to publish their data to a global and public address book
• In server A, add server B as a trusted server
• In server B, add server A as a trusted server

Now both servers need to trust each other. This is done using background jobs, so either force somehow the jobs to run or wait patiently until they run :-) (or, if you are using the AJAX method, entertain yourself reloading pages on each server around 30 times, although you need to do it alternatively as the jobs need to run in both servers :party:). There are probably much better ways to do it, but in order to know when the servers have trusted each other you can print a log message in TrustedServers::addSharedSecret

Once the servers trust each other, synchronize their address books running occ federation:sync-addressbooks in both servers. If the sharing settings are then opened again the other server should be shown as trusted and synchronized.

Now, if you open the Contacts menu in any of the servers you will see the users from the other server.

[danxuliu]

/backport to stable21

[nickvergessen]

Please note that this might need to be adjusted in the mobile apps as well. Should the property in the capabilities be renamed too?

Not renamed, but we actually need 2 capabilities?

[danxuliu]

Not renamed, but we actually need 2 capabilities?

I have checked and if the federation app is disabled in server B it is no longer possible to synchronize its users from server A. So I guess that it would make sense to hide the Federated scope if the federation app is disabled.

However, if I am not mistaken in the WebUI the Federated scope was never hidden before, so I do not know if there is a special reason for that or if it was just an oversight 🤷

[nickvergessen]

However, if I am not mistaken in the WebUI the Federated scope was never hidden before, so I do not know if there is a special reason for that or if it was just an oversight shrug

Before @PVince81 recent work all scope settings were always hidden when the settings was off. Now it only hides the federation+published one as the others still make sense

[blizzz]

So what's to do with this?

[danxuliu]

Besides the initial fix the Federated option is now hidden when the Federation app is disabled, and the capability was split in two different capabilities.

[skjnldsv]

@danxuliu rebase? close?

[danxuliu]

Rebased and ready to review again.

[Pytal]

👍 will carry this over to Vue for 23 :)

Vuetification of the Personal info settings page has been postponed, should get this in :)

[nickvergessen]

/backport to stable22

[nickvergessen]

I guess we backport to 22 before to 21