rework search api to allow searching on multiple caches at once #26874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
single-query-search
branch
6 times, most recently
from
0f50fe1 to
0d97f7e
Compare
icewind1991
force-pushed
the
single-query-search
branch
6 times, most recently
from
7cf651e to
acf974c
Compare
icewind1991
changed the title
icewind1991
added
3. to review
blizzz
reviewed
Jun 2, 2021
blizzz
reviewed
Jun 2, 2021
blizzz
reviewed
Jun 2, 2021
skjnldsv
approved these changes
Jun 2, 2021
skjnldsv
added
4. to release
icewind1991
force-pushed
the
single-query-search
branch
from
acf974c to
097fc68
Compare
|
rebase fixed ci :) |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
single-query-search
branch
from
097fc68 to
ca4a931
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
single-query-search
branch
from
ca4a931 to
362cb2a
Compare
juliusknorr
approved these changes
Jun 16, 2021
|
Can this be backported to 21? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes file search from having each storage's cache perform the cache to asking each cache for how to filter search results, combining all filters from every cache and running the search in a single query.
The results are then passed to the caches again to allow post-processing before finally turning them into the final result objects.
This way there is only a single query required for the search no matter how many storages a user has access to, this does come at the cost of a more complex query but it should still be a good improvement overall