[WIP] Dont allow reusing usernames #27105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasReschke
commented
May 25, 2021
LukasReschke
commented
May 25, 2021
LukasReschke
commented
May 25, 2021
nickvergessen
requested changes
May 25, 2021
LukasReschke
commented
May 26, 2021
LukasReschke
force-pushed
the
dont-allow-reusing-usernames
branch
13 times, most recently
from
48d982b to
f3c6d2f
Compare
LukasReschke
force-pushed
the
dont-allow-reusing-usernames
branch
4 times, most recently
from
99a2b22 to
8355ea5
Compare
nickvergessen
approved these changes
May 31, 2021
We have cases in which app developers forget to delete user data when a user is being deleted. This could be problematic as future users with the same username could then access this data. This mitigates this risk a bit by not allowing reusing of usernames. That said, we still need to fix occurrences of these issues by deleting missed data. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
force-pushed
the
dont-allow-reusing-usernames
branch
from
8355ea5 to
1d5cbd3
Compare
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
nickvergessen
approved these changes
Jun 4, 2021
|
Should put into #26407 as I guess this will break the tests of a lot of apps :-X |
|
There was 1 error:
/home/runner/work/server/server/apps/files_sharing/lib/External/MountProvider.php:75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have cases in which app developers forget to delete user data when a user is being deleted. This could be problematic as future users with the same username could then access this data.
This mitigates this risk a bit by not allowing reusing of usernames. That said, we still need to fix occurrences of these issues by deleting missed data.
Test plan
There is currently no feedback in the UI but that is due to another bug, which also affects other errors such as the ones by an enforced password policy: #27115
TODOs