-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump underscore from 1.12.0 to 1.12.1 #27279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
@dependabot rebase |
490d981
to
310933c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
310933c
to
d767c5e
Compare
Breaks the tests for some reason 🤔 |
Looks like jashkenas/underscore#2918 |
d767c5e
to
e3165a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
e3165a1
to
efecef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
efecef6
to
180caff
Compare
180caff
to
422784a
Compare
@MichaIng let's pause this upgrade until investigation |
422784a
to
0e76c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
0e76c98
to
5d8342d
Compare
|
I'm trying to understand the underlying issue:
Taken the above is correct, I see
|
A newer version of underscore exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot recreate |
5d8342d
to
aef8244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
/compile amend / |
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/jashkenas/underscore/releases) - [Commits](jashkenas/underscore@1.12.0...1.12.1) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
aef8244
to
4b42972
Compare
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
fixed by #30020 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>
Bumps underscore from 1.12.0 to 1.12.1.
Commits
c627e38
Mention CVE-2021-23358 in code, test and documentation (#2915)c9e803e
Add diff and docs to the 1.12.1 change log entry0c20985
Restore comments from 7e89b79f95e7bbf5a0ed
Merge branch 'template-variable-parameter'7e3d404
Update annotated sources and minified bundles for 1.12.15343fbc
Add version 1.12.1 to the documentation44df929
Bump the version to 1.12.17e89b79
Un-document the fix for #2911 for the time being4c73526
Fix #2911ef646cc
Reflect real issue of #2911 in test from #2912Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)