Add missing ACLs for deleted calendar objects to fix deletion #27343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
st3iny,
tcitworld,
kesselb,
GretaD and
skjnldsv
2 tasks
ChristophWurst
force-pushed
the
fix/deleted-objects-deletion-missing-acls
branch
from
9cf8ff3 to
8451975
Compare
kesselb
approved these changes
Jun 2, 2021
Due to a bug in Sabre it's necessary for calendar objects to implement ACLs. Otherwise the scheduling plugin will throw an error when it tries to fetch the owner of a calendar object that is being deleted. Ref sabre-io/dav#1345 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/deleted-objects-deletion-missing-acls
branch
from
8451975 to
fc8daf5
Compare
GretaD
approved these changes
Jun 2, 2021
ChristophWurst
added
4. to release
tcitworld
reviewed
Jun 2, 2021
| return [ | ||
| [ | ||
| 'privilege' => '{DAV:}read', // For queries | ||
| 'principal' => $this->getOwner(), |
There was a problem hiding this comment.
Is there a difference between returning the actual owner principal URI and {DAV:}owner? If the former is required, might as well put it everywhere?
There was a problem hiding this comment.
There is no difference right now. There might be one once we allow the trash bin access for shared calendars
tcitworld
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in Sabre it's necessary for calendar objects to implement
ACLs. Otherwise the scheduling plugin will throw an error when it tries
to fetch the owner of a calendar object that is being deleted.
Ref sabre-io/dav#1345
Required for nextcloud/calendar#3129