Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Emails UI and Integration #27379

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Multiple Emails UI and Integration #27379

merged 5 commits into from
Jul 15, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 4, 2021 •
edited
Loading

To Do

  • Rewrite php markup and functionality in Vue apps/settings/templates/settings/personal/persona.info.php
  • Pass initial state from server to client
  • Rewrite js functionality in Vue federationsettingsview.js
    • Save primary email address (with deletion)
    • Federation control
      • With reference to federationscopemenu.js and federationsettingsview.js
      • Override @nextcloud/vue component styles to match non-Vue federation controls
    • Password confirmation
    • Success/Error icon on save
    • Error handling
    • Verification
      • Looks like the verify functionality in apps/settings/js/settings/personalInfo.js line 157 isn't used anymore as it is only shown when both email is not empty and scope is public but scope is never public as found in lib/public/Accounts/IAccountManager.php
      • Not implementing at the moment as it seems unused?
  • Validation
    • Vanilla js validation (e.g. checkValidity())
  • Debounce API calls
  • Additional email functionality
    • Only allow adding an additional email input if all current inputs are valid
    • Add additional email
    • Delete additional email
    • Update additional email
    • Federation control for additional emails
    • Design updates from Jan
      • 3-dot menu on the right of each input field
        • One dropdown entry called "Delete email"
      • Add button with "+" and "Add" label, flush to the right
  • Create constants file (to be kept in sync with lib/public/Accounts/IAccountManager.php
  • Automaticaly set next additonal email as primary on deletion of primary email [UX]

🐞 Bugs

Note: The TODO comments are out-of-scope for this PR and will be addressed separately in future PRs

Contributes to #26866

@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from 6c1cab3 to 94803ca Compare June 4, 2021 17:30
@Pytal Pytal self-assigned this Jun 4, 2021
@Pytal Pytal added the 2. developing Work in progress label Jun 4, 2021
@Pytal Pytal added this to the Nextcloud 22 milestone Jun 4, 2021
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch 2 times, most recently from c1e2b05 to 9e6f35f Compare June 8, 2021 02:27
@Pytal Pytal changed the title Multiple Emails UI Multiple Emails UI & Integration Jun 8, 2021
@Pytal Pytal changed the title Multiple Emails UI & Integration Multiple Emails UI and Integration Jun 8, 2021
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from 9e6f35f to 58c1e89 Compare June 8, 2021 14:32
@MichaIng MichaIng linked an issue Jun 8, 2021 that may be closed by this pull request
Multiple Email addresses #26866
Open
9 tasks
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from 58c1e89 to 35c079a Compare June 9, 2021 00:54
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch 2 times, most recently from 9df74ae to 7c341c9 Compare June 9, 2021 17:08
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@artonge

This comment has been minimized.

Sign in to view
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from cfbd701 to 9d60401 Compare July 13, 2021 22:51
@Pytal

This comment has been minimized.

Sign in to view
@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from 9d60401 to 096ad01 Compare July 13, 2021 23:28
juliusknorr
juliusknorr approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code looks good 👍

@Pytal Pytal force-pushed the feat/26866/multiple-emails-ui branch from 096ad01 to 8e58b1b Compare July 14, 2021 23:06
@skjnldsv
Copy link
Member

Please rebase and LGTM 🚀

Pytal added 5 commits July 15, 2021 10:16
@Pytal @skjnldsv
Provide initial state
ef41d59 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @skjnldsv
Create personal info service
de6e550 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @skjnldsv
Make emails Vuetiful
4476357 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @skjnldsv
Refine UX for primary email deletion
64403d2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @skjnldsv
Build
aa92c9e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv force-pushed the feat/26866/multiple-emails-ui branch from 8e58b1b to aa92c9e Compare July 15, 2021 08:45
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 15, 2021
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit 28b0e81 into master Jul 15, 2021
@juliusknorr juliusknorr deleted the feat/26866/multiple-emails-ui branch July 15, 2021 10:01
@juliusknorr
Copy link
Member

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@Pytal Pytal mentioned this pull request Jul 15, 2021
Open
9 tasks
@skjnldsv
Copy link
Member

@Pytal can you backport this manually please? :)

@Pytal Pytal removed a link to an issue Jul 15, 2021
Multiple Email addresses #26866
Open
9 tasks
@Pytal
Copy link
Member Author

Pytal commented Jul 15, 2021

@Pytal can you backport this manually please? :)

You bet ;)

@Pytal Pytal mentioned this pull request Jul 16, 2021
Merged
@nursoda nursoda mentioned this pull request Sep 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@MichaIng MichaIng Awaiting requested review from MichaIng

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: settings
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
7 participants
@Pytal @skjnldsv @artonge @juliusknorr @ChristophWurst @blizzz @MichaIng