Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex to match Windows 10 calendar user-agent #27488

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add regex to match Windows 10 calendar user-agent #27488

merged 1 commit into from
Jun 29, 2021

Conversation

msrn
Copy link
Contributor

@msrn msrn commented Jun 12, 2021

This pull requests adds Windows 10 calendar to the list of user-agents in WebCalCaching -plugin, and exposes subscribed calendars to Windows 10 calendar client.

Typical user-agent string for Windows 10 Calendar is: MSFT-WIN-3/10.0.19041
Included regex matches, the MSFT-WIN-3 part only.

Considers #17754

@tcitworld

@tcitworld
Copy link
Member

apps/dav/tests/unit/CalDAV/WebcalCaching/PluginTest.php needs to be updated as well, by replacing the empty array [] with

Plugin::ENABLE_FOR_CLIENTS

See the test failure https://drone.nextcloud.com/nextcloud/server/6224/9/4

@tcitworld tcitworld added 3. to review Waiting for reviews feature: dav php Pull requests that update Php code labels Jun 14, 2021
@tcitworld
Copy link
Member

@msrn Please run php-cs-fixer to lint your changes.

@szaimen szaimen added this to the Nextcloud 23 milestone Jun 18, 2021
ChristophWurst
ChristophWurst approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@msrn
Copy link
Contributor Author

msrn commented Jun 22, 2021

Do I need to squash this to a single commit?

@ChristophWurst
Copy link
Member

Do I need to squash this to a single commit?

It's usually preferred, yes :)

@msrn
Add regex to match Windows 10 calendar user-agent
14c33bb 
* Match first part of the Windows 10 calendar user-agent
* Exposes subscribed calendars for Windows 10 calendar
* Update unit test

Signed-off-by: Mikael Saarinen <mikaels@iki.fi>
@msrn msrn force-pushed the win10cal-useragent branch from 6c41336 to 14c33bb Compare June 23, 2021 06:51
@msrn
Copy link
Contributor Author

msrn commented Jun 23, 2021

Do I need to squash this to a single commit?

It's usually preferred, yes :)

Squashed, and rebased to master aswell

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 23, 2021
@juliusknorr juliusknorr merged commit d1b0ccb into nextcloud:master Jun 29, 2021
@welcome
Copy link

welcome bot commented Jun 29, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@msrn msrn deleted the win10cal-useragent branch August 28, 2022 20:28
@msrn msrn mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: dav php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
5 participants
@msrn @tcitworld @ChristophWurst @juliusknorr @szaimen