better error messages if the users home is not writable during scanning #27538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
scanner-home-not-writable-better-errors
branch
from
8d1feec to
406e8cb
Compare
|
Fixes #26634 What's missing to finish this ? |
Good question. Ping @icewind1991 |
|
Can you guys also add checking whether files directory exists within users home directories? I just spent a few days debugging this very issue and finally fixed it by following advice from this post: |
Merged
skjnldsv
added
3. to review
skjnldsv
requested review from
a team,
nickvergessen,
CarlSchwan and
come-nc
and removed request for
a team
|
/rebase |
nextcloud-command
force-pushed
the
scanner-home-not-writable-better-errors
branch
from
406e8cb to
1c7ca79
Compare
come-nc
requested changes
Oct 25, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
icewind1991
force-pushed
the
scanner-home-not-writable-better-errors
branch
from
1c7ca79 to
978722b
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
scanner-home-not-writable-better-errors
branch
from
978722b to
54f6135
Compare
icewind1991
requested review from
come-nc,
a team,
ArtificialOwl,
blizzz and
artonge
and removed request for
a team
artonge
approved these changes
Apr 5, 2023
come-nc
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26634