Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Login with device page styles #27566

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Update Login with device page styles #27566

merged 1 commit into from
Jun 22, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 18, 2021

Closes #27530

image
image
image

@nextcloud/designers

@Pytal Pytal self-assigned this Jun 18, 2021
@Pytal Pytal added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Jun 18, 2021
@Pytal Pytal added this to the Nextcloud 22 milestone Jun 18, 2021
artonge
artonge requested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Can you update the css selectors to use BEM ?

@Pytal Pytal force-pushed the fix/device-login-styles branch from 8498ab0 to d157625 Compare June 21, 2021 22:17
@Pytal
Copy link
Member Author

Pytal commented Jun 21, 2021

/compile amend /core/js

@Pytal
Copy link
Member Author

Pytal commented Jun 21, 2021

Looks good !

Can you update the css selectors to use BEM ?

Scoped class has been updated to use BEM, other classes used from guest.css have been left unchanged. Is this good or would copying guest.css style declarations into the scoped style section be preferred?

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/device-login-styles branch from d157625 to b17e5b0 Compare June 21, 2021 22:26
@Pytal Pytal force-pushed the fix/device-login-styles branch 2 times, most recently from 06a3c30 to 7b3f510 Compare June 21, 2021 22:32
@Pytal
Update login with device page styles
08d59bb 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/device-login-styles branch from 7b3f510 to 08d59bb Compare June 21, 2021 22:40
@artonge
Copy link
Contributor

artonge commented Jun 22, 2021 •
edited
Loading

Scoped class has been updated to use BEM, other classes used from guest.css have been left unchanged. Is this good or would copying guest.css style declarations into the scoped style section be preferred?

Yes, fine, let's not make this PR bigger than necessary :).

@LukasReschke LukasReschke merged commit d1001f7 into master Jun 22, 2021
@LukasReschke LukasReschke deleted the fix/device-login-styles branch June 22, 2021 09:49
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 22, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@GretaD GretaD Awaiting requested review from GretaD

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Login with device page is not properly styled
4 participants
@Pytal @artonge @ChristophWurst @LukasReschke