Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jasmine-core from 2.5.2 to 2.99.1 in /build #28141

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2021

Bumps jasmine-core from 2.5.2 to 2.99.1.

Release notes

Sourced from jasmine-core's releases.

2.99.1

This is a patch release to fix the deprecation message for catch exceptions in 2.99

See #1497

2.99

This release deprecates some things in preparation for Jasmine 3.0. Please see the release notes

2.9.1

Please see the release notes

2.9.0

Please see the release notes

2.8.0

Please see the release notes.

2.7.0

Please see the release notes.

2.6.4

Please see the release notes

2.6.3

Please see the release notes

2.6.2

Please see the release notes

2.6.1

Please see the release notes

2.6.0

Please see the release notes

Commits
  • 4e5d947 Also lock for selenium runner
  • c2603ef Specify Jasmine Gem 2.99 tag for bundle install
  • fbec3cc Only show deprecation for catch exceptions if you tell Jasmine not to catch
  • 4530f94 Generate combined file with new version numbers
  • 9911d37 bump version to 2.99
  • 32f99ef Use Jasmine's arrayContains to look for duplicate deprecations
  • c142490 Add deprecation messages for things that will change/break in 3.0
  • 24bf348 Display deprecation warnings in HTML reporter
  • 5afe122 Add ability to report deprecation warnings from within the suite
  • 70bce55 Bump version to 2.9.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link
Member

@nextcloud-bot nextcloud-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@MichaIng MichaIng added 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress and removed 3. to review Waiting for reviews 1. to develop Accepted and waiting to be taken care of labels Jul 25, 2021
@MichaIng MichaIng added this to the Nextcloud 23 milestone Jul 25, 2021
@szaimen

This comment has been minimized.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from 9bbc78a to ef59b78 Compare August 31, 2021 02:39
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from ef59b78 to 7ed6332 Compare August 31, 2021 09:56
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@nextcloud nextcloud deleted a comment from dependabot bot Aug 31, 2021
@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from 470269b to b30522a Compare September 23, 2021 13:26
@MichaIng MichaIng force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from b30522a to fece5a5 Compare September 23, 2021 13:39
@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from fece5a5 to 50f3ffe Compare September 23, 2021 13:54
@MichaIng
Copy link
Member

MichaIng commented Sep 23, 2021

Error:

  Apps base tests
    Sidebar utility functions
      ✗ shows sidebar
	Uncaught SyntaxError: Failed to execute 'open' on 'XMLHttpRequest': Invalid URL thrown

Not sure where this test involves a request/URL: https://github.com/nextcloud/server/blob/dependabot/npm_and_yarn/build/jasmine-core-2.99.1/core/js/tests/specs/appsSpec.js#L31-L35

And:

  Core base tests
    Notifications
      showTemporary
        ✗ shows a plain text notification with default timeout
	Expected 2 to equal 1.
	    at UserContext.<anonymous> (core/js/tests/specs/coreSpec.js:620:25)

I think it means there are two notifications while only one is expected? https://github.com/nextcloud/server/blob/dependabot/npm_and_yarn%2Fbuild%2Fjasmine-core-2.99.1/core/js/tests/specs/coreSpec.js#L616-L622

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from 50f3ffe to 024b9bd Compare October 20, 2021 18:15
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 2.5.2 to 2.99.1.
- [Release notes](https://github.com/jasmine/jasmine/releases)
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine@v2.5.2...v2.99.1)

---
updated-dependencies:
- dependency-name: jasmine-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch from 024b9bd to 7de8285 Compare November 17, 2021 02:06
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@nextcloud nextcloud deleted a comment from dependabot bot Dec 19, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 18, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@MichaIng
Copy link
Member

Obsolete as of: #30718

@MichaIng MichaIng closed this Jan 18, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 18, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/build/jasmine-core-2.99.1 branch January 18, 2022 16:39
@MichaIng MichaIng removed this from the Nextcloud 24 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants