Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures when building settings app #28202

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Fix CI failures when building settings app #28202

merged 2 commits into from
Jul 29, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 28, 2021

Closes #28201

May or may not be feasible, please take into account some additonal context in the PR introducing chunkhash here #22395

@Pytal Pytal added the 3. to review Waiting for reviews label Jul 28, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Jul 28, 2021
@Pytal Pytal self-assigned this Jul 28, 2021
@skjnldsv skjnldsv mentioned this pull request Jul 28, 2021
Merged
@MichaIng
Copy link
Member

I haven't really noticed that its the settings app only, but indeed. Could then make skjnldsv/npmbuildbot#174 obsolete, although there may be other reasons for renamed files.

As John approved, I guess #21024 would not appear again? Looks like the existence of an old nextcloud/settings dir was at least part of the issue.

@skjnldsv
Copy link
Member

As John approved, I guess #21024 would not appear again?

Seems like it works now yep 🤔
Webpack changed a lot in between 🤞

@julien-nc julien-nc mentioned this pull request Jul 28, 2021
Merged
@Pytal Pytal force-pushed the settings-app-webpack branch from 512a3bc to 640d9f6 Compare July 28, 2021 20:18
Pytal added 2 commits July 28, 2021 22:43
@Pytal
Remove chunkhash
63c3b9a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Build
decfc2e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the settings-app-webpack branch from 640d9f6 to decfc2e Compare July 28, 2021 22:58
@Pytal
Copy link
Member Author

Pytal commented Jul 28, 2021 •
edited
Loading

CI is going haywire atm 💀, for the node workflow errors I believe the ubuntu-latest images were updated recently and as such no longer include python2 which node-gyp depends on as seen in the logs, resolutions welcome :)

Also saw that we're using self-hosted runners skjnldsv-runner-o87nbcrcbnm40cv059kebobmk and skjnldsv-runner-mvh6njed8c0viktutgaz1nk13 so @skjnldsv might know more?

@skjnldsv
Copy link
Member

skjnldsv commented Jul 29, 2021 •
edited
Loading

Also saw that we're using self-hosted runners skjnldsv-runner-o87nbcrcbnm40cv059kebobmk and skjnldsv-runner-mvh6njed8c0viktutgaz1nk13

It was testing to go faster but it doesn't seems to work :(
EDIT: oh wow, it seems to work now 🤦

@skjnldsv
Copy link
Member

EDIT: oh wow, it seems to work now

I deactivated them because of actions/runner#406

@juliusknorr juliusknorr merged commit 6f1c2ed into master Jul 29, 2021
@juliusknorr juliusknorr deleted the settings-app-webpack branch July 29, 2021 07:31
@MichaIng
Copy link
Member

MichaIng commented Jul 29, 2021 •
edited
Loading

The self-hosted runners seem to have issues to pick up queries actions. I recognised it starting yesterday, you can see it now when filtering actions by status "queried", there are lots stalled up to three hours. Yesterday I manually cancelled all of them (the obviously stalled ones), to see whether, once clean, this solves the issue.

@julien-nc julien-nc mentioned this pull request Jul 30, 2021
Merged
@Pytal
Copy link
Member Author

Pytal commented Jul 30, 2021

/backport to stable22

@Pytal
Copy link
Member Author

Pytal commented Jul 30, 2021

/backport to stable21

@Pytal
Copy link
Member Author

Pytal commented Jul 30, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

This was referenced Jul 31, 2021
Merged
Merged
@Pytal
Copy link
Member Author

Pytal commented Jul 31, 2021 •
edited
Loading

Backports:

stable22 #28274
stable21 #28275
stable20 #28305

@skjnldsv
Copy link
Member

Hum, i'm not sure about backporting though 🤔
What do you think @juliushaertl ? Safe enough?

@juliusknorr
Copy link
Member

Would be fine for me since we use that chunkName pattern in lots of other places without issues, though I'd wait for the next round of maintennace releases as we are in rc already.

@Pytal Pytal mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@artonge artonge Awaiting requested review from artonge

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Settings app build output hashes cause CI failures
4 participants
@Pytal @MichaIng @skjnldsv @juliusknorr