Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.sample.php #28637

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Update config.sample.php #28637

merged 2 commits into from
Oct 13, 2021

Conversation

JensTimmerman
Copy link
Contributor

fixes #21674

mteam88
mteam88 approved these changes Aug 29, 2021
View reviewed changes
Copy link

@mteam88 mteam88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to help clarity.

@szaimen szaimen added the 3. to review Waiting for reviews label Aug 31, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Aug 31, 2021
szaimen
szaimen approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021 •
edited
Loading

/run/postgresql/ is definitely correct on Debian and Ubuntu 👍. The trailing slash can be omitted, though: /run/postgresql

@JensTimmerman
Can you squash and signoff the commits, to satisfy DCO? At least me cannot merge otherwise.

@mteam88
Copy link

mteam88 commented Sep 3, 2021

@JensTimmerman
Please fix DCO.

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 13, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@kesselb kesselb merged commit b7ee885 into nextcloud:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mteam88 mteam88 mteam88 approved these changes

@szaimen szaimen szaimen approved these changes

@MichaIng MichaIng MichaIng approved these changes

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

occ maintenance:install fails when Postgres is socket-only
5 participants
@JensTimmerman @MichaIng @mteam88 @szaimen @kesselb