Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config.php option for transfer ownership #28847

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Add config.php option for transfer ownership #28847

merged 1 commit into from
Sep 15, 2021
+7 −0

Conversation

PVince81
Copy link
Member

For #28118

Add option to specify whether to transfer incoming shares by default.

@PVince81 PVince81 added the 3. to review Waiting for reviews label Sep 15, 2021
@PVince81 PVince81 self-assigned this Sep 15, 2021
@PVince81
Copy link
Member Author

/backport to stable22

@PVince81 PVince81 mentioned this pull request Sep 15, 2021
Merged
@solracsf
Copy link
Member

solracsf commented Sep 15, 2021 •
edited
Loading

Even if it's obvious, maybe inserting something like:

"Defaults to false, so incoming shares are not transfered unless specifically requested"

ipasanec
ipasanec reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@ipasanec ipasanec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a note like 'Can be overwritten by command line argument.' might be helpful. (just a thought)

@PVince81 PVince81 force-pushed the techdebt/28118/update-config-sample-for-transfer-ownership-defaults branch from b2d1fd8 to 5621b8a Compare September 15, 2021 12:52
@PVince81
Add config.php option for transfer ownership
04385c7 
Add option to specify whether to transfer incoming shares by default.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the techdebt/28118/update-config-sample-for-transfer-ownership-defaults branch from 5621b8a to 04385c7 Compare September 15, 2021 12:56
@PVince81
Copy link
Member Author

@acsfer @ipasanec adjusted, please recheck

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 15, 2021
@szaimen szaimen added the pending documentation This pull request needs an associated documentation update label Sep 15, 2021
@PVince81 PVince81 merged commit 1162dcd into master Sep 15, 2021
@PVince81 PVince81 deleted the techdebt/28118/update-config-sample-for-transfer-ownership-defaults branch September 15, 2021 14:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 15, 2021
Merged
@PVince81
Copy link
Member Author

doc is here: nextcloud/documentation#7134

removing label

@PVince81 PVince81 removed the pending documentation This pull request needs an associated documentation update label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipasanec ipasanec ipasanec approved these changes

@solracsf solracsf solracsf approved these changes

Assignees

@PVince81 PVince81

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @solracsf @ipasanec @szaimen