Add SCHEME_NULL to list of allowed auth mechanism #28941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋
I guess we already allow using the system credentials when using object store. Looks okay to me to allow this for external storages as well. Yet it's possible to allow users to mount their own storages (when the admin allows). Then also end user could use the global credentials. |
kesselb
added
2. developing
howardZa
force-pushed
the
feature/allow_s3_access_wo_auth
branch
2 times, most recently
from
7afe66a
to
5d08f35
Compare
kesselb
requested review from
a team,
PVince81,
icewind1991 and
blizzz
and removed request for
a team
Merged
icewind1991
approved these changes
Nov 12, 2021
|
/rebase |
szaimen
added
4. to release
Add Auth::Mechanism::SCHEME_NULL to list of allowed auth mechanism for AmazonS3 backend to allow attaching S3 storage to nextcloud instances running on already authorized instances (e.g. EC2 instances with IAM Instance roles) Signed-off-by: Wolfram Gries <wolfram.gries@zapooflex.net>
szaimen
force-pushed
the
feature/allow_s3_access_wo_auth
branch
from
5d08f35
to
5c821c7
Compare
|
manually rebased |
|
ready to merge, imho |
|
samba failure unrelated |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AuthMechanism::SCHEME_NULL to list of allowed auth mechanism for AmazonS3 backend to allow attaching S3 storage to nextcloud instances running on already authorized instances (e.g. EC2 instances with IAM Instance roles)
USE CASE: When running nextcloud on AWS resources (eg. EC2 instances / EKS kubernetes pods), these instances can be associated with IAM roles that permit access to S3 buckets. In this case, no access-key is needed to access the bucket.
The files_external S3 configuration normally insists on the configuration of an Access-Key.
ADVANTAGES: By not using access keys to authorize access to the buckets the credentials do not need to be exposed and the management of IAM permissions is a little bit easier.