Allow "TwoFactor Nextcloud Notifications" to pull the state of the 2FA again #29056
Conversation
|
/backport to stable22 |
|
/backport to stable21 |
…A again Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/allow-twofactor-nextcloud-notifications-to-work-again
branch
from
35c115d to
3710eca
Compare
nickvergessen
requested review from
a team,
PVince81,
ArtificialOwl and
icewind1991
and removed request for
a team
|
/backport to stable20 |
nickvergessen
changed the title
| if ($controller instanceof APIController && $methodName === 'poll') { | ||
| // Allow polling the twofactor nextcloud notifications state | ||
| return; | ||
| } |
There was a problem hiding this comment.
Does this work if the app is not locally installed? - If yes: LGTM.
There was a problem hiding this comment.
afaik doing instanceof with a non existing class gracefully returns false
There was a problem hiding this comment.
Yes it works, same as ::class (which is what this uses internally I guess)
nickvergessen
deleted the
bugfix/noid/allow-twofactor-nextcloud-notifications-to-work-again
branch
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
| @@ -82,6 +83,11 @@ public function __construct(Manager $twoFactorManager, Session $userSession, ISe | |||
| * @param string $methodName | |||
| */ | |||
| public function beforeController($controller, $methodName) { | |||
| if ($controller instanceof APIController && $methodName === 'poll') { | |||
There was a problem hiding this comment.
Is there a way we could have fixed this bug without introducing app-specifics into the server code base? 🤔
There was a problem hiding this comment.
I guess we could introduce another annotation which is like @PublicPageButWith(out)ExtraSteps
…A again