Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDocument flat mimetypes and x-office/drawing alias #29157

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

juliusknorr
Copy link
Member

Required for nextcloud/richdocuments#1342 and nextcloud/richdocuments#1470 to support more mimetypes.

New icon introduced for application/vnd.oasis.opendocument.graphics which is aliased to x-office/drawing in case we might add other similar file formats.

image

Existing office icons for comparison:

image

@jancborchardt Please have a look at the icon. Feedback is very welcome.

@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Oct 11, 2021
@juliusknorr juliusknorr requested review from jancborchardt, a team, PVince81, ArtificialOwl, CarlSchwan and skjnldsv and removed request for a team October 11, 2021 07:07
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Oct 11, 2021
@juliusknorr juliusknorr requested review from luka-nextcloud and julien-nc and removed request for PVince81 and ArtificialOwl October 11, 2021 07:08
@skjnldsv
Copy link
Member

Could use a bit of svgo ;)

@jancborchardt
Copy link
Member

This now uses the "draw-io" icon though instead of the mimetype icon you made in nextcloud/richdocuments#1470, no? Looks a bit off since it’s a similar orange as presentations, just more vibrant – for "LibreOffice Drawings" I would use the yellow one you made.

@juliusknorr
Copy link
Member Author

This now uses the "draw-io" icon though instead of the mimetype icon you made in nextcloud/richdocuments#1470, no? Looks a bit off since it’s a similar orange as presentations, just more vibrant – for "LibreOffice Drawings" I would use the yellow one you made.

Ok, then I'll update the icon to that one which just needs a bit more polishing for the shape alignment.

@jancborchardt
Copy link
Member

jancborchardt commented Oct 11, 2021

@juliushaertl note that there is a draw.io integration app which probably uses that icon: https://apps.nextcloud.com/apps/drawio
Would it be possible for the mimetype that this app uses to use the draw.io orange one, and for the one that Collabora Online Draw uses to use the yellow one? (Or are they the same mimetype?)

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 11, 2021

The drawio app uses a custom mimetype application/x-drawio for files with a .drawio extension which are basically xml.

Libreoffice draw uses a yellow-orange mix color, same for the Collabora Office branding:

image

image

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 11, 2021

@jancborchardt I'm not really happy with the results in both cases especially with smaller sizes, but the "diagram" icon one seems a bit better to me still.

(16px/24px/32px/64px)

image
image

Any further ideas for that?

@jancborchardt
Copy link
Member

Yeah, do we then want to use the "diagram" icon in both cases – yellow for LO draw, orange for draw.io (if possible)?

@juliusknorr
Copy link
Member Author

I'd say it makes sense for the mimetype to offer that as a generic one in the server. Currently the draw.io app implements that on their own but they could certainly then also just use our diagram mimetype icon.

@jancborchardt
Copy link
Member

I'd say it makes sense for the mimetype to offer that as a generic one in the server. Currently the draw.io app implements that on their own but they could certainly then also just use our diagram mimetype icon.

Yep, absolutely 👍

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Updated to this one now:

image

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@juliusknorr
Copy link
Member Author

Let's see if CI is happy about those test adjustments, runs fine locally now at least.

Will fix the php-cs then after the ci run.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants