-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenDocument flat mimetypes and x-office/drawing alias #29157
Conversation
Could use a bit of svgo ;) |
This now uses the "draw-io" icon though instead of the mimetype icon you made in nextcloud/richdocuments#1470, no? Looks a bit off since it’s a similar orange as presentations, just more vibrant – for "LibreOffice Drawings" I would use the yellow one you made. |
Ok, then I'll update the icon to that one which just needs a bit more polishing for the shape alignment. |
@juliushaertl note that there is a draw.io integration app which probably uses that icon: https://apps.nextcloud.com/apps/drawio |
@jancborchardt I'm not really happy with the results in both cases especially with smaller sizes, but the "diagram" icon one seems a bit better to me still. (16px/24px/32px/64px) Any further ideas for that? |
Yeah, do we then want to use the "diagram" icon in both cases – yellow for LO draw, orange for draw.io (if possible)? |
I'd say it makes sense for the mimetype to offer that as a generic one in the server. Currently the draw.io app implements that on their own but they could certainly then also just use our diagram mimetype icon. |
Yep, absolutely 👍 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
0d40d48
to
0d2e05a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
Let's see if CI is happy about those test adjustments, runs fine locally now at least. Will fix the php-cs then after the ci run. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
1a28541
to
2f38781
Compare
Required for nextcloud/richdocuments#1342 and nextcloud/richdocuments#1470 to support more mimetypes.
New icon introduced for
application/vnd.oasis.opendocument.graphics
which is aliased to x-office/drawing in case we might add other similar file formats.Existing office icons for comparison:
@jancborchardt Please have a look at the icon. Feedback is very welcome.