Add current status in navbar #29210
Merged
Add current status in navbar #29210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
da53431 to
c551db0
Compare
CarlSchwan
requested review from
jancborchardt,
artonge,
a team,
PVince81 and
szaimen
and removed request for
a team
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
c551db0 to
282bec1
Compare
|
/compile amend / |
|
Tooltip seems to not live update? Should subscribe to: |
jancborchardt
requested changes
Oct 13, 2021
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
282bec1 to
c896ddc
Compare
|
/compile amend / |
I just removed the tooltip completely, since as the comment from Jan point out we get the same info when clicking on the menu :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
c896ddc to
58e450e
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
work/status-navbar-vue
branch
from
58e450e to
3e53b9d
Compare
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
3e53b9d to
0e0f2a0
Compare
nextcloud-command
force-pushed
the
work/status-navbar-vue
branch
from
0e0f2a0 to
c222467
Compare
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
c222467 to
0e0f2a0
Compare
nextcloud-command
force-pushed
the
work/status-navbar-vue
branch
from
0e0f2a0 to
50c77e0
Compare
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
3 times, most recently
from
a1d5a0e to
fcf50ac
Compare
|
/compile amend / |
jancborchardt
approved these changes
Oct 13, 2021
nextcloud-command
force-pushed
the
work/status-navbar-vue
branch
from
fcf50ac to
8d0890c
Compare
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
8d0890c to
48a3a95
Compare
|
/compile amend / |
CarlSchwan
added
the
4. to release
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
48a3a95 to
6510477
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
work/status-navbar-vue
branch
from
6510477 to
749a3ca
Compare
PVince81
requested changes
Oct 13, 2021
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
749a3ca to
a1522f1
Compare
|
Tests fails |
|
Test failure is not unrelated: ldap server disconnected. I'm going to squash the commits and then merge this with admin right (ci is really too slow currently) |
This ports the code to vue and if the user_status app is disabled this goes back to the previous behavior. The Avatar vue components detects changes of the status automatically. Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Joas Schilling <coding@schilljs.com>
CarlSchwan
force-pushed
the
work/status-navbar-vue
branch
from
370c188 to
134167e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the code to Vue and if the user_status app is disabled this
goes back to the previous behavior.
The Avatar vue component detects changes of the status automatically.
Signed-off-by: Carl Schwan carl@carlschwan.eu