Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect mimetype by content only with content #29454

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Detect mimetype by content only with content #29454

merged 1 commit into from
Oct 27, 2021

Conversation

nickvergessen
Copy link
Member

Steps

  1. Add an access rule which only allows folders and documents by mimetype
  2. Upload a 0 byte file with test.docx as name
  3. Afterwards refresh the folder
  4. File is blocked, debugger says mimetype is application/octet-stream

@nickvergessen
Detect mimetype by content only with content
7a6d559 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 27, 2021
@nickvergessen nickvergessen requested review from blizzz, a team, ArtificialOwl and icewind1991 and removed request for a team October 27, 2021 08:49
@blizzz blizzz merged commit 1666bb0 into master Oct 27, 2021
@blizzz blizzz deleted the bugfix/noid/detect-mimetype-by-content-only-with-content branch October 27, 2021 12:26
@blizzz
Copy link
Member

blizzz commented Oct 27, 2021

backports required?

@nickvergessen
Copy link
Member Author

/backport to stable22

@nickvergessen
Copy link
Member Author

/backport to stable21

@nickvergessen
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 27, 2021
Merged
This was referenced Oct 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz blizzz approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: workflows
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @blizzz @juliusknorr