[stable22] Fix removing remote shares when the remote server is unreachable #29565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The federated server needs to be stopped during the tests, so it is now stopped in the FederationContext for each scenario instead of just once in the run.sh script. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Technically, saying that a storage has no updates when it's not available is correct. This makes it possible to retrieve the cache entry for the mount point and also to list and remove unavailable federated shares. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
danxuliu,
icewind1991,
juliusknorr,
nickvergessen and
skjnldsv
|
let's hold for now as this changes the behavior of unavailable external storages |
MichaIng
approved these changes
Nov 6, 2021
skjnldsv
approved these changes
Nov 8, 2021
Does it fix #20995? |
|
moved to 22.2.2 |
|
Should this be merged now? |
|
Ping |
Merged
|
@PVince81 ping |
|
I still feel a bit scared to merge this in 22. on the other hand, we didn't see any related federated share issues for 23 so far |
changes look ok imo, but i would not know whether there are possible side effects. So, merge now, keep open and merge later, or close (m/k/c)? |
blizzz
approved these changes
Mar 10, 2022
|
Vincent said merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25332