Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish availibility settings #29590

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Polish availibility settings #29590

merged 1 commit into from
Nov 9, 2021

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 8, 2021 •
edited
Loading

fixes #29319

@GretaD

This comment has been minimized.

Sign in to view
@GretaD GretaD self-assigned this Nov 8, 2021
@GretaD GretaD added 2. developing Work in progress enhancement labels Nov 8, 2021
@ChristophWurst
Copy link
Member

Im failing to understand why i cannot style add slot button. It is shown correctly only when we have 2 slots like on Friday.

Where is it shown incorrectly?

@GretaD
Copy link
Contributor Author

GretaD commented Nov 8, 2021

Im failing to understand why i cannot style add slot button. It is shown correctly only when we have 2 slots like on Friday.

Where is it shown incorrectly?

All the other days is positioned a bit down. When we have one slot, or no slots.

@GretaD GretaD force-pushed the enhanc/availibility_settings_polishing branch from 9478a83 to 512f7cc Compare November 8, 2021 15:36
@GretaD GretaD marked this pull request as ready for review November 8, 2021 15:36
@GretaD GretaD requested a review from ChristophWurst November 8, 2021 15:36
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 8, 2021
@GretaD GretaD added this to the Nextcloud 23 milestone Nov 8, 2021
@GretaD GretaD requested a review from miaulalala November 8, 2021 15:40
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
Merged
23 tasks
@GretaD
Copy link
Contributor Author

GretaD commented Nov 8, 2021

availabilitysettings

@GretaD GretaD force-pushed the enhanc/availibility_settings_polishing branch 2 times, most recently from 3a07459 to bdb76eb Compare November 9, 2021 09:30
@GretaD GretaD requested a review from ChristophWurst November 9, 2021 09:37
@ChristophWurst
Copy link
Member

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enhanc/availibility_settings_polishing branch from bdb76eb to 7ca989c Compare November 9, 2021 10:15
@GretaD @ChristophWurst
Polish availibility settings
3b22d19 
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@ChristophWurst ChristophWurst force-pushed the enhanc/availibility_settings_polishing branch from 7ca989c to 3b22d19 Compare November 9, 2021 10:58
@ChristophWurst ChristophWurst requested a review from st3iny November 9, 2021 16:49
@ChristophWurst ChristophWurst merged commit 52f8f4a into master Nov 9, 2021
@ChristophWurst ChristophWurst deleted the enhanc/availibility_settings_polishing branch November 9, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

CalDAV availibility settings design polishing
3 participants
@GretaD @ChristophWurst @st3iny