Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print verbose info about app updates if there are none #29708

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Do not print verbose info about app updates if there are none #29708

merged 1 commit into from
Nov 22, 2021

Conversation

ChristophWurst
Copy link
Member

This is cosmetic but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.

Before

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Setting log level to debug
Turned on maintenance mode
Updating database schema
Updated database
Disabled incompatible app: mail
Updating <calendar> ...
Updated <calendar> to 2.4.0-RC.2
Checking for update of app accessibility in appstore
Checked for update of app "accessibility" in App Store 
Checking for update of app admin_audit in appstore
Checked for update of app "admin_audit" in App Store 
Checking for update of app calendar in appstore
Checked for update of app "calendar" in App Store 
Checking for update of app cloud_federation_api in appstore
Checked for update of app "cloud_federation_api" in App Store 
Checking for update of app comments in appstore
Checked for update of app "comments" in App Store 
Checking for update of app contactsinteraction in appstore
Checked for update of app "contactsinteraction" in App Store 
Checking for update of app dashboard in appstore
Checked for update of app "dashboard" in App Store 
Checking for update of app dav in appstore
Checked for update of app "dav" in App Store 
Checking for update of app federatedfilesharing in appstore
Checked for update of app "federatedfilesharing" in App Store 
Checking for update of app federation in appstore
Checked for update of app "federation" in App Store 
Checking for update of app files in appstore
Checked for update of app "files" in App Store 
Checking for update of app files_external in appstore
Checked for update of app "files_external" in App Store 
Checking for update of app files_sharing in appstore
Checked for update of app "files_sharing" in App Store 
Checking for update of app files_trashbin in appstore
Checked for update of app "files_trashbin" in App Store 
Checking for update of app files_versions in appstore
Checked for update of app "files_versions" in App Store 
Checking for update of app lookup_server_connector in appstore
Checked for update of app "lookup_server_connector" in App Store 
Checking for update of app oauth2 in appstore
Checked for update of app "oauth2" in App Store 
Checking for update of app provisioning_api in appstore
Checked for update of app "provisioning_api" in App Store 
Checking for update of app settings in appstore
Checked for update of app "settings" in App Store 
Checking for update of app sharebymail in appstore
Checked for update of app "sharebymail" in App Store 
Checking for update of app systemtags in appstore
Checked for update of app "systemtags" in App Store 
Checking for update of app theming in appstore
Checked for update of app "theming" in App Store 
Checking for update of app twofactor_backupcodes in appstore
Checked for update of app "twofactor_backupcodes" in App Store 
Checking for update of app updatenotification in appstore
Checked for update of app "updatenotification" in App Store 
Checking for update of app user_ldap in appstore
Checked for update of app "user_ldap" in App Store 
Checking for update of app user_status in appstore
Checked for update of app "user_status" in App Store 
Checking for update of app viewer in appstore
Checked for update of app "viewer" in App Store 
Checking for update of app weather_status in appstore
Checked for update of app "weather_status" in App Store 
Checking for update of app workflowengine in appstore
Checked for update of app "workflowengine" in App Store 
Checking for update of app mail in appstore
Checked for update of app "mail" in App Store 
Update successful
Turned off maintenance mode
Resetting log level

After

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Setting log level to debug
Turned on maintenance mode
Updating database schema
Updated database
Updating <calendar> ...
Updated <calendar> to 2.4.0-RC.3
Update successful
Turned off maintenance mode
Resetting log level

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Nov 15, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Nov 15, 2021
@ChristophWurst ChristophWurst self-assigned this Nov 15, 2021
@ChristophWurst ChristophWurst requested review from come-nc and removed request for a team November 15, 2021 13:37
PVince81
PVince81 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please make fixup bot happy

@ChristophWurst
Do not print verbose info about app updates if there are none
781ec81 
This is cosmetical but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/no-app-update-no-verbose branch from 49637ef to 781ec81 Compare November 18, 2021 08:11
@MichaIng
Copy link
Member

Great, I was annoyed but this as well. I vote for backport to Nextcloud 23 at least.

@MichaIng
Copy link
Member

/backport to stable23

@MichaIng MichaIng merged commit 2631f48 into master Nov 22, 2021
@MichaIng MichaIng deleted the fix/no-app-update-no-verbose branch November 22, 2021 02:22
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 22, 2021
Merged
@MichaIng
Copy link
Member

/backport to stable22

@MichaIng
Copy link
Member

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 22, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 PVince81 approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@jotoeri jotoeri Awaiting requested review from jotoeri

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @MichaIng @nickvergessen @PVince81 @CarlSchwan