Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make profile page usable on mobile #29833

Merged
merged 1 commit into from
Nov 23, 2021
Merged

make profile page usable on mobile #29833

merged 1 commit into from
Nov 23, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 22, 2021 •
edited
Loading

Fix #29340

Before After
192 168 146 130_8443_index php_u_admin(Moto G4) (1) 192 168 146 130_8443_index php_u_admin(Moto G4)

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/29340/fix-mobile-profilepage \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 2. developing Work in progress labels Nov 22, 2021
@szaimen szaimen added this to the Nextcloud 24 milestone Nov 22, 2021
@szaimen szaimen force-pushed the fix/29340/fix-mobile-profilepage branch from d381a4f to 2299d48 Compare November 22, 2021 12:21
@nextcloud-command nextcloud-command force-pushed the fix/29340/fix-mobile-profilepage branch from 2299d48 to a852445 Compare November 22, 2021 12:35
@szaimen szaimen force-pushed the fix/29340/fix-mobile-profilepage branch from a852445 to 8f94ac0 Compare November 22, 2021 12:47
@nextcloud-command nextcloud-command force-pushed the fix/29340/fix-mobile-profilepage branch from 8f94ac0 to 72caa6d Compare November 22, 2021 12:56
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 22, 2021
@szaimen szaimen requested review from Pytal, juliusknorr, a team and PVince81 and removed request for a team November 22, 2021 13:08
@szaimen
Copy link
Contributor Author

szaimen commented Nov 22, 2021

/backport to stable23

@Pytal Pytal mentioned this pull request Nov 22, 2021
Open
20 tasks
@szaimen szaimen force-pushed the fix/29340/fix-mobile-profilepage branch from 72caa6d to 888ed1e Compare November 22, 2021 23:52
@nextcloud-command nextcloud-command force-pushed the fix/29340/fix-mobile-profilepage branch 2 times, most recently from 19ca344 to 4c44ab5 Compare November 23, 2021 00:23
@szaimen szaimen force-pushed the fix/29340/fix-mobile-profilepage branch from 4c44ab5 to e6de2c4 Compare November 23, 2021 00:29
@szaimen
Copy link
Contributor Author

szaimen commented Nov 23, 2021

/compile amend /

@szaimen szaimen requested a review from juliusknorr November 23, 2021 00:30
@nextcloud-command nextcloud-command force-pushed the fix/29340/fix-mobile-profilepage branch from e6de2c4 to 885624d Compare November 23, 2021 00:54
Pytal
Pytal approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

@szaimen szaimen force-pushed the fix/29340/fix-mobile-profilepage branch 2 times, most recently from e562150 to 77e51ac Compare November 23, 2021 09:08
@szaimen
Copy link
Contributor Author

szaimen commented Nov 23, 2021

/compile amend /

@szaimen @nextcloud-command
make profile page usable on mobile
4d92f42 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/29340/fix-mobile-profilepage branch from 77e51ac to 4d92f42 Compare November 23, 2021 09:18
@szaimen
Copy link
Contributor Author

szaimen commented Nov 23, 2021 •
edited
Loading

I've just rebased the PR and solved conflicts

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 23, 2021
@szaimen szaimen merged commit a72af6a into master Nov 23, 2021
@szaimen szaimen deleted the fix/29340/fix-mobile-profilepage branch November 23, 2021 10:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Profile page is not usable on mobile
4 participants
@szaimen @juliusknorr @artonge @Pytal