Improve accessibility of the title of the settings #29881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
artonge,
a team,
nickvergessen,
juliusknorr and
come-nc
and removed request for
a team
CarlSchwan
force-pushed
the
fix/setting/accessibility-title
branch
from
45ecafe
to
5ca06d7
Compare
artonge
requested changes
Nov 24, 2021
come-nc
reviewed
Nov 25, 2021
Merged
Merged
Before every setting page had the same title and this is causing issues for screenreaders since they can't differenciate the title of page. Now a new variable is available for apps to declare the page subtitle. This new variable is implemented for the settings app and while at it I added a bit more type hinting to the stuff I touched :) Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/setting/accessibility-title
branch
from
5ca06d7
to
046d545
Compare
come-nc
approved these changes
May 17, 2022
artonge
approved these changes
May 17, 2022
PVince81
added
4. to release
|
@CarlSchwan please merge if this is still relevant, considering recent changes to the settings pages |
Merged
Merged
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before every setting page had the same title and this is causing issues
for screenreaders since they can't differenciate the title of page. Now
a new variable is available for apps to declare the page subtitle.
This new variable is implemented for the settings app and while at it I
added a bit more type hinting to the stuff I touched :)
Signed-off-by: Carl Schwan carl@carlschwan.eu