Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bigint for autoincremented column #30254

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Use bigint for autoincremented column #30254

merged 2 commits into from
Dec 14, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 13, 2021

Fix #30239

@Pytal Pytal added bug 3. to review Waiting for reviews feature: install and update feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Dec 13, 2021
@Pytal Pytal added this to the Nextcloud 24 milestone Dec 13, 2021
@Pytal Pytal requested a review from a team December 13, 2021 20:01
@Pytal Pytal self-assigned this Dec 13, 2021
@Pytal Pytal requested review from PVince81, icewind1991, juliusknorr and nickvergessen and removed request for a team December 13, 2021 20:01
@Pytal
Copy link
Member Author

Pytal commented Dec 13, 2021

/backport to stable23

Pytal added 2 commits December 14, 2021 00:12
@Pytal
Use bigint for autoincremented column
c85ab47 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Migrate profile_config id column to bigint
c85f78d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/30239/use-bigint branch from bd165ce to c85f78d Compare December 14, 2021 00:14
PVince81
PVince81 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

jackpot! the two tests that usually randomly fail have failed at the same time in this PR

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2021
@Pytal Pytal merged commit 98b637f into master Dec 14, 2021
@Pytal Pytal deleted the fix/30239/use-bigint branch December 14, 2021 21:31
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

profile_config table is not using bigint for autoincrement column
3 participants
@Pytal @PVince81 @nickvergessen