-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable23] Remove iconv from dependencies and tests #30351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added
the
pending documentation
This pull request needs an associated documentation update
label
Dec 20, 2021
/backport to stable22 |
/backport to stable21 |
come-nc
approved these changes
Dec 20, 2021
Related docs update: nextcloud/documentation#7864 |
MichaIng
force-pushed
the
backport/29958/stable23
branch
from
December 31, 2021 16:33
e9bb290
to
110d5bf
Compare
which is not used anymore since: #29470 Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
force-pushed
the
backport/29958/stable23
branch
from
January 4, 2022 02:07
110d5bf
to
022d005
Compare
blizzz
approved these changes
Jan 6, 2022
The backport to stable22 failed. Please do this backport manually. |
The backport to stable21 failed. Please do this backport manually. |
Manual backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of: #29958
As of: #29965
I removed
iconv
from some additional tests which were missed before, assured to catch all cases viagrep -ir
now 😉. Done formaster
here: #30352Requires a backport of the documentation change: nextcloud/documentation#7860