Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all CalDAV PHP classes strict #30437

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Backend.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Filter/Calendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Filter/Todo.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Provider/Base.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Provider/Calendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Provider/Event.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Provider/Todo.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Setting/Calendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Setting/Event.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Activity/Setting/Todo.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/BirthdayCalendar/EnablePlugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2017, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
8 changes: 7 additions & 1 deletion apps/dav/lib/CalDAV/CalDavBackend.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
* @copyright Copyright (c) 2018 Georg Ehrke
Expand Down Expand Up @@ -90,6 +93,7 @@
use Sabre\VObject\Component\VTimeZone;
use Sabre\VObject\DateTimeParser;
use Sabre\VObject\InvalidDataException;
use Sabre\VObject\Parameter;
use Sabre\VObject\ParseException;
use Sabre\VObject\Property;
use Sabre\VObject\Reader;
Expand Down Expand Up @@ -3017,8 +3021,10 @@ public function updateProperties($calendarId, $objectUri, $calendarData, $calend
$parameters = $property->parameters();
$indexedParametersForProperty = self::$indexParameters[$property->name];

foreach ($parameters as $key => $value) {
foreach ($parameters as $key => $parameter) {
/** @var Parameter $parameter */
if (in_array($key, $indexedParametersForProperty)) {
$value = $parameter->getValue();
// is this a shitty db?
if ($this->db->supports4ByteText()) {
$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Calendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/CalendarHome.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/CalendarManager.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2017, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/CalendarObject.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
* @copyright Copyright (c) 2017, Georg Ehrke
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/CalendarRoot.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/ICSExportPlugin/ICSExportPlugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2019, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Integration/ExternalCalendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2020, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Integration/ICalendarProvider.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2020, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2018, Georg Ehrke.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Outbox.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2018, Georg Ehrke
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Plugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud GmbH.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Principal/Collection.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017, Christoph Seitz <christoph.seitz@posteo.de>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Principal/User.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017, Christoph Seitz <christoph.seitz@posteo.de>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/PublicCalendar.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017, Georg Ehrke
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/PublicCalendarObject.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017, Georg Ehrke
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/PublicCalendarRoot.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Publishing/PublishPlugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Thomas Citharel <tcit@tcit.fr>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016 Thomas Citharel <tcit@tcit.fr>
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2019, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2018, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright 2018, Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
* @copyright Copyright (c) 2017, Georg Ehrke
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Schedule/Plugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2016, Roeland Jago Douma <roeland@famdouma.nl>
* @copyright Copyright (c) 2016, Joas Schilling <coding@schilljs.com>
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/SearchPlugin.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/CompFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/LimitFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/OffsetFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/ParamFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/PropFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
3 changes: 3 additions & 0 deletions apps/dav/lib/CalDAV/Search/Xml/Filter/SearchTermFilter.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2017 Georg Ehrke <oc.list@georgehrke.com>
*
Expand Down