-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete files before cleaning cache when cleaning user files #30510
Conversation
/backport to stable23 |
/backport to stable22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, nice catch 👍
@icewind1991 we might still be missing a cleanup job that will remove orphaned object store entries that have no matching filecache entries ? (separate issue) |
/rebase |
otherwise, when using object store, we loose track of which files the user owns before we can delete them Signed-off-by: Robin Appelman <robin@icewind.nl>
83d73b5
to
db3093a
Compare
Thanks for the PR it is nice! @PVince81 we just created a little go job to do just that: We thought first to do it in php, but well, we don't have that much experience in php, and with the goroutine and the 100k of objects we had to clean 🤷♂️ |
so, should reset the label to 2 - developing? |
this PR is still valid as it should prevent future cases |
/backport to stable24 |
The backport to stable24 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
The backport to stable22 failed. Please do this backport manually. |
otherwise, when using object store, we loose track of which files the user owns before we can delete them
Signed-off-by: Robin Appelman robin@icewind.nl