Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] add better index for finding unindexed paths #30598

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[stable22] add better index for finding unindexed paths #30598

merged 1 commit into from
Jan 13, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 11, 2022 •
edited by icewind1991
Loading

backport of #29118

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.4 milestone Jan 11, 2022
@PVince81
Copy link
Member

@icewind1991 please resolve the conflict

@solracsf solracsf added the 2. developing Work in progress label Jan 13, 2022
@icewind1991
add better index for finding unindexed paths
9f2b50d 
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the backport/29118/stable22 branch from f2346dd to 9f2b50d Compare January 13, 2022 14:45
@icewind1991
Copy link
Member

rebased

PVince81
PVince81 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichaIng MichaIng merged commit 3622942 into stable22 Jan 13, 2022
@MichaIng MichaIng deleted the backport/29118/stable22 branch January 13, 2022 22:01
@blizzz blizzz mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge artonge approved these changes

@MichaIng MichaIng MichaIng approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 22.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@PVince81 @icewind1991 @artonge @MichaIng @solracsf