Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large sidebar previews for text files #306

Merged
merged 4 commits into from
Jul 4, 2016
Merged

Conversation

icewind1991
Copy link
Member

Before:

before

After:

after

Instead of showing a small, unreadable image of the text, we load in the full text to make it easy to quickly tell the contents of a file.
The size of the text preview is the same as the preview of (landscape) images and long texts can be scrolled.

This also adds the ability for apps to register custom thumbnails.

cc @nextcloud/designers

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 4, 2016
@icewind1991 icewind1991 added this to the Nextcloud Next milestone Jul 4, 2016
@jancborchardt
Copy link
Member

Just a small detail: since it's text, it should have some margin to the sides unlile images. (My computer is in repair today, can't do it. :( Just give it the same amount of margin/padding the content below it has.)

@MorrisJobke
Copy link
Member

Just a small detail: since it's text, it should have some margin to the sides unlile images. (My computer is in repair today, can't do it. :( Just give it the same amount of margin/padding the content below it has.)

I will do.

@MorrisJobke
Copy link
Member

With my change it looks like this:

bildschirmfoto 2016-07-04 um 15 37 25

@jancborchardt
Copy link
Member

Can we get rid of the excess whitespace below if the text file is short? Looks good otherwise!

@MorrisJobke
Copy link
Member

Can we get rid of the excess whitespace below if the text file is short? Looks good otherwise!

I will give this a try.

@MorrisJobke
Copy link
Member

I fixed it:

short text:
bildschirmfoto 2016-07-04 um 17 37 50
more text:
bildschirmfoto 2016-07-04 um 17 37 54
images:
bildschirmfoto 2016-07-04 um 17 37 57

@MorrisJobke
Copy link
Member

👍 from me for the actual feature

@williambargent
Copy link
Member

👍

1 similar comment
@MariusBluem
Copy link
Member

👍

@MariusBluem MariusBluem merged commit 865e244 into master Jul 4, 2016
@MariusBluem MariusBluem deleted the sidebar-preview-text branch July 4, 2016 19:36
@MariusBluem
Copy link
Member

THX.

@jancborchardt
Copy link
Member

Great work everyone! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants