Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Prevent loading images that would require too much memory. #30602

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[stable23] Prevent loading images that would require too much memory. #30602

merged 1 commit into from
Jan 12, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #30291

@fancycode @backportbot
Prevent loading images that would require too much memory.
cebac86 
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.1 milestone Jan 11, 2022
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jan 11, 2022
@blizzz blizzz merged commit 6d2b690 into stable23 Jan 12, 2022
@blizzz blizzz deleted the backport/30291/stable23 branch January 12, 2022 10:16
@blizzz blizzz mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@come-nc come-nc Awaiting requested review from come-nc

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: previews and thumbnails
Projects
None yet
Milestone
Nextcloud 23.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @fancycode @blizzz