New Files internal link GET param to avoid opening the file #30645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
3. to review
julien-nc
requested review from
a team,
PVince81,
artonge and
Pytal
and removed request for
a team
|
if the default behavior is to open the file, how about calling it "openfile=0" to disable it, and the default would be "openfile=1" ? or is that less intuitive ? |
julien-nc
force-pushed
the
enh/internal-link-scroll-only
branch
from
15319ed to
e0e976f
Compare
|
@PVince81 Yes, makes sense. Done and pushed. |
artonge
approved these changes
Jan 13, 2022
|
Thank you both for the review. What do you think about backporting that? |
Pytal
approved these changes
Jan 14, 2022
As long as this doesn't change existing functionality up to you :) |
Agreed! |
…direct Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
enh/internal-link-scroll-only
branch
from
e0e976f to
b67b4b1
Compare
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
|
CI failure is not related. |
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
openfileGET param to internal links (/f/FILE_ID) to avoid setting theopenfileparam in the redirect response.This can be useful when the intention is to show the file's activity for example.
It is already possible to get there with links like
https://my.nc.org/index.php/apps/files/?dir=/&scrollto=name.txtbut it requires to know the file path.