Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Param 'overwritecondaddr' not working #30654

Closed
wants to merge 2 commits into from
Closed

Config Param 'overwritecondaddr' not working #30654

wants to merge 2 commits into from

Conversation

pavelkryl
Copy link
Contributor

@pavelkryl pavelkryl commented Jan 13, 2022

just ignoring/removing extra parameter 'protocol' as suggested by blizzz
Fix #6914

- just ignoring/removing extra parameter 'protocol' as suggested by
  blizzz

Signed-off-by: Pavel Kryl <pavel@kryl.eu>
@blizzz blizzz requested review from a team, nickvergessen, ArtificialOwl and skjnldsv and removed request for a team January 13, 2022 19:03
@blizzz blizzz added 3. to review Waiting for reviews bug labels Jan 13, 2022
@blizzz blizzz added this to the Nextcloud 24 milestone Jan 13, 2022
@nickvergessen nickvergessen removed their request for review January 13, 2022 19:27
@blizzz blizzz requested a review from PVince81 January 13, 2022 20:14
@solracsf solracsf changed the title fixing bug #6914: Config Param 'overwritecondaddr' not working Config Param 'overwritecondaddr' not working Jan 13, 2022
@CarlSchwan
Copy link
Member

Hi :) could you fix the DCO issue? You can find instructions here: https://github.com/nextcloud/server/pull/30654/checks?check_run_id=4808469925

The drone pipeline is failing but it's unrelated to this change

@solracsf
Copy link
Member

Ping @pavelkryl

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
@blizzz blizzz mentioned this pull request Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@pavelkryl can you please fix DCO? Otherwise we cannot merge this change unfortunately :/

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2023
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@blizzz
Copy link
Member

blizzz commented Jan 18, 2024

continuation of this pr at #42930

@blizzz blizzz closed this Jan 18, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Param 'overwritecondaddr' not working
6 participants