Improve layout for the public download page #30655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
a team,
PVince81,
artonge and
Pytal
and removed request for
a team
Closed
This centers the content inside the pages, while also not hardcoded the size of the footer. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/sizing-publi-download-page
branch
from
5a7b2d6 to
2e55ce0
Compare
|
@CarlSchwan Your screenshot does not have the 3 lines at the bottom (just enter a disclaimer on the |
|
Works fine :)
Also added a non-breaking space in the file size displays, I noticed in my screenshot that it was needed |
solracsf
approved these changes
Jan 13, 2022
skjnldsv
approved these changes
Jan 14, 2022
skjnldsv
added
4. to release
|
Tests are failing due to the non breaking space, i will look into it |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/sizing-publi-download-page
branch
from
183357c to
46c0ceb
Compare
|
Should I do a backport? Since this fixes the issue with the footer size not working correctly then there is a privacy policy |
I vote for yes |
|
Ok for backport to me @CarlSchwan |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centers the content inside the pages, while also not hardcoded the
size of the footer and removing an annoying small vertical scroll.
Before:
After:
Signed-off-by: Carl Schwan carl@carlschwan.eu