Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve layout for the public download page" #30752

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

max-nextcloud
Copy link
Contributor

This reverts commit 30decc3.

There were still some issues with the layout in #30723. So revert the commit that broke text editing and probably also the grid layout.

@max-nextcloud max-nextcloud added this to the Nextcloud 22.2.4 milestone Jan 19, 2022
This reverts commit 30decc3.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the fix/stable22/public-shares branch from 7e6556f to bdd677c Compare January 19, 2022 08:53
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. What do we do with stable23 and master?

@max-nextcloud
Copy link
Contributor Author

max-nextcloud commented Jan 19, 2022

Looking at the failing tests in CI:

  1. https://drone.nextcloud.com/nextcloud/server/14378/1/3
    reason seems to be that
The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result
  1. /drone/src/tests/acceptance/features/app-files-tags.feature:22
  2. /drone/src/tests/acceptance/features/users.feature:13

@max-nextcloud
Copy link
Contributor Author

Looking at the failing tests in CI:

1. https://drone.nextcloud.com/nextcloud/server/14378/1/3

Also failed for the parent.

@nickvergessen nickvergessen merged commit ea84427 into stable22 Jan 19, 2022
@welcome
Copy link

welcome bot commented Jan 19, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nickvergessen nickvergessen deleted the fix/stable22/public-shares branch January 19, 2022 10:47
This was referenced Jan 20, 2022
@max-nextcloud max-nextcloud restored the fix/stable22/public-shares branch September 6, 2022 12:10
@max-nextcloud max-nextcloud deleted the fix/stable22/public-shares branch September 6, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants