Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in profiler #30823

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Built-in profiler #30823

merged 1 commit into from
Apr 4, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jan 24, 2022 •
edited by nickvergessen
Loading

Repo for the webui is here: https://github.com/nextcloud/profiler (needs to be compiled)

image

image

image

@CarlSchwan CarlSchwan marked this pull request as draft January 24, 2022 09:23
@CarlSchwan
Copy link
Member Author

image

There is now a debug toolbar that also link to the profiler of the AJAX requests made in the background :)

@CarlSchwan
Copy link
Member Author

image

More progress now with a cache module

@nickvergessen nickvergessen mentioned this pull request Feb 18, 2022
Merged
come-nc
come-nc requested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be files and copyrights from accessibility app that are not needed here (fonts, img…)

.htaccess Outdated Show resolved Hide resolved
apps/dav/lib/Profiler/ProfilerPlugin.php Show resolved Hide resolved
apps/dav/lib/Profiler/ProfilerPlugin.php Outdated Show resolved Hide resolved
apps/profiler/README.md Outdated Show resolved Hide resolved
apps/profiler/appinfo/info.xml Outdated Show resolved Hide resolved
PVince81
PVince81 reviewed Mar 3, 2022
View reviewed changes
apps/dav/lib/Server.php Outdated Show resolved Hide resolved
@CarlSchwan CarlSchwan marked this pull request as ready for review March 14, 2022 14:44
@CarlSchwan CarlSchwan changed the title WIP: Built-in profiler Built-in profiler Mar 14, 2022
@CarlSchwan CarlSchwan self-assigned this Mar 14, 2022
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Mar 14, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Mar 14, 2022
@CarlSchwan
Copy link
Member Author

ui is now at https://github.com/CarlSchwan/nextcloud-profiler

come-nc
come-nc reviewed Mar 14, 2022
View reviewed changes
apps/dav/lib/Server.php Outdated Show resolved Hide resolved
come-nc
come-nc reviewed Mar 14, 2022
View reviewed changes
apps/dav/lib/Server.php Outdated Show resolved Hide resolved
artonge
artonge reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of code scanning errors

@CarlSchwan
Copy link
Member Author

There are still a lot of code scanning errors

fixed now

@come-nc
Copy link
Contributor

come-nc commented Mar 15, 2022

@since comments are needed in all new files in lib/public: https://drone.nextcloud.com/nextcloud/server/16694/1/3
You also need to run composer run cs:fix.

And there are missing return types on some of the new methods, please add them.

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@CarlSchwan CarlSchwan requested a review from come-nc March 29, 2022 20:06
skjnldsv
skjnldsv approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc
Copy link
Contributor

come-nc commented Mar 30, 2022

From drone:

@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::add
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::loadProfileFromResponse
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::loadProfile
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::saveProfile
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::find
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::dataProviders
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::isEnabled
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::setEnabled
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfiler::collect
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getToken
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setToken
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getTime
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setTime
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getUrl
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setUrl
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getMethod
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setMethod
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getStatusCode
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setStatusCode
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::addCollector
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getParent
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setParent
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getParentToken
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getChildren
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setChildren
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::addChild
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getCollectors
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::setCollectors
@since or @deprecated tag is needed in PHPDoc for OCP\Profiler\IProfile::getCollector
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\IDataCollector::collect
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\IDataCollector::reset
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\IDataCollector::getName
PHPDoc is needed for OCP\DataCollector\AbstractDataCollector::getName
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\AbstractDataCollector::reset
PHPDoc is needed for OCP\DataCollector\AbstractDataCollector::__sleep
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\AbstractDataCollector::serialize
@since or @deprecated tag is needed in PHPDoc for OCP\DataCollector\AbstractDataCollector::unserialize
PHPDoc is needed for OCP\DataCollector\AbstractDataCollector::jsonSerialize

@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
nickvergessen
nickvergessen reviewed Mar 31, 2022
View reviewed changes
lib/private/DB/DbDataCollector.php Show resolved Hide resolved
lib/private/DB/ObjectParameter.php Show resolved Hide resolved
lib/private/Memcache/LoggerWrapperCache.php Show resolved Hide resolved
lib/private/Memcache/ProfilerWrapperCache.php Show resolved Hide resolved
lib/private/Profiler/Profile.php Show resolved Hide resolved
lib/public/DataCollector/AbstractDataCollector.php Outdated Show resolved Hide resolved
lib/public/DataCollector/IDataCollector.php Outdated Show resolved Hide resolved
lib/public/Profiler/IProfile.php Show resolved Hide resolved
@CarlSchwan CarlSchwan force-pushed the work/profiler branch 2 times, most recently from 9585ae8 to 924f16c Compare March 31, 2022 20:00
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 1, 2022
@CarlSchwan CarlSchwan force-pushed the work/profiler branch 2 times, most recently from c97f89f to 77dbc57 Compare April 1, 2022 11:29
@CarlSchwan
Add a built-in profiler inside Nextcloud
7d272c5 
The webui is provided by a seperate application named profiler

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit 135bdb3 into master Apr 4, 2022
@CarlSchwan CarlSchwan deleted the work/profiler branch April 4, 2022 10:56
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@PVince81 PVince81 PVince81 left review comments

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
6 participants
@CarlSchwan @come-nc @nickvergessen @PVince81 @artonge @skjnldsv