Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use persistent connections when connecting to redis #30959

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

icewind1991
Copy link
Member

Keeping the connection open can help reduce the overhead of connecting to redis and reduce the load of the redis server

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 1, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Feb 1, 2022
Signed-off-by: Robin Appelman <robin@icewind.nl>
@juliusknorr
Copy link
Member

Seems to work quite well, but I needed to set a redis.pconnect.connection_limit to something low in order to have an observable effect on my smaller scale test setup.

@PVince81 PVince81 merged commit fbbbc2e into master Feb 11, 2022
@PVince81 PVince81 deleted the redis-pconnect branch February 11, 2022 15:18
@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

backport or skip ? @juliushaertl

@juliusknorr
Copy link
Member

Backport makes sense 👍

@juliusknorr
Copy link
Member

/backport to stable23

@juliusknorr
Copy link
Member

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants