Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Add primary key for ratelimit table #30966

Merged
merged 4 commits into from
Mar 10, 2022
Merged

[stable22] Add primary key for ratelimit table #30966

merged 4 commits into from
Mar 10, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 2, 2022 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #30235

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.4 milestone Feb 2, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Feb 2, 2022 •
edited
Loading

  • Needs a version bump once stable is unblocked

@MichaIng MichaIng added the 2. developing Work in progress label Feb 3, 2022
@blizzz blizzz mentioned this pull request Feb 11, 2022
Merged
12 tasks
@blizzz blizzz mentioned this pull request Mar 9, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Mar 10, 2022

@nickvergessen what's the state here?

@nickvergessen
Add a primary key to ratelimit_entries table
3532802 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the DB query simpler (as we just deleted all other entries)
4fe5cef 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update autoloader
1e2e3d1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Bump version
c818ac6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the backport/30235/stable22 branch from d0333e2 to c818ac6 Compare March 10, 2022 13:24
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2022
@nickvergessen
Copy link
Member

Rebased and adjusted

PVince81
PVince81 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 10, 2022
@blizzz blizzz merged commit 143b691 into stable22 Mar 10, 2022
@blizzz blizzz deleted the backport/30235/stable22 branch March 10, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@miaulalala miaulalala Awaiting requested review from miaulalala

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 22.2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @PVince81 @MichaIng