Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] Update variables.scss - Fallback font before Noto Color Emoji #30968

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25418

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.4 milestone Feb 2, 2022
@MichaIng MichaIng added the 3. to review Waiting for reviews label Feb 3, 2022
@blizzz blizzz mentioned this pull request Feb 11, 2022
12 tasks
@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2022

/rebase

I would put sans-serif before Noto Color Emoji. If you have none of the previous fonts installed but Noto Color Emoji is, the interface looks very ugly because it uses Noto Color Emoji then. That's exactly the case on my linux distribution.
@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2022

failing tests are unrelated

@szaimen szaimen merged commit e26c56b into stable22 Mar 8, 2022
@szaimen szaimen deleted the backport/25418/stable22 branch March 8, 2022 12:50
@blizzz blizzz mentioned this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants