-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ?view=grid
query param to allow shared links to default to grid view
#31159
Conversation
…lt to grid view Signed-off-by: Chuck Dries <chuck@chuckdries.com>
0d86454
to
824f26d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems good but I can’t judge the code. :)
Relevant code to pick this up will then have to be implemented in
- the Photos app
- in Files, we could automatically invoke this in a share link when the sender has the folder view set to grid?
I'm not a nextcloud developer but this doesn't seem like a clean implementation. This is useful as a quick and dirty hack in the meantime for people needing the feature, but breaks too many things to be part of the official code. Currently grid view is set to false in apps/files_sharing/lib/Controller/ShareController.php. Changing it to true works as expected: grid view is shown as initial view for all shared folders. An UI setting should be added when creating share link for initial view, and the controller should use it to set initial value of 'showgridview'. Of course this is all my humble opinion. |
I'm no php developer but I'll take a shot at that this weekend |
I'm sorry, to ask here but I'm still figuring things out... Do I read this history correctly, that it was merged to Nextcloud 24 RC 1? Any help would be appreciated 🙈 |
This PR was not merged. Sorry, but I didn't get around to making the requested changes and no longer have time or desire to do so. |
inspired by https://help.nextcloud.com/t/question-display-grid-view-when-sharing-a-folder-of-photos-via-url/56812/8
fixes #17762
I'm open to attempting to improve on any of the bullet points above if requested