Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient). #31220

StCyr · 2022-02-16T17:36:49Z

This PR implements #31005

With this change, passwords protecting public non-anonymous shares become temporary: They have an expiration time and a background job changes them to some random undisclosed value when their expiration time is passed.

To request a new temporary password, recipients use a new "request password" button that is added to protected public non-anonymous shares' authentication page. This button serves the same functionality as the "request password" button implemented by Talk (ie: To identify the person requesting the password), except that, here, the person identifies herself by proving she knows the email address with which the file is shared with (ie: she types her email address, and if it matches the email address with which the file is shared the person is considered "identified" and a new temporary password is sent to that email address). Of course, identification via a Talk session takes precedence when the share has its "video verification" attribute checked.

I'm waiting for your reviews and welcome your comments which I hope will be constructive

Cyrille

===============================
UPDATE 20220217:

The existing protected public non-anonymous shares are not impacted by this change (they don't have a password_expiration_time, so the expiration background job doesn't consider them)
The temporary passwords are valid for 1 day.

===============================
UPDATE 20220223:
I've created a new branch: https://github.com/nextcloud/server/tree/enhancement/31005/temporary-passwords-v2

Compared to this branch, this new branch brings the following:

password_expiration_time is now checked during password check. This also makes the expiration background job not necessary anymore;
Temporary passwords validity period is now configurable via a system value

apps/files_sharing/lib/BackgroundJob/ResetExpiredPasswordsJob.php

PVince81 · 2022-03-01T09:37:02Z

did you forget to push something ?

please run build/autoloaderchecker.sh

Fixed in7fffe20e0c324c158d60b51799ec5f0f1a8f6230

PVince81 · 2022-03-01T09:44:53Z

apps/files_sharing/lib/BackgroundJob/ResetExpiredPasswordsJob.php

+use \OCP\Security\IHasher;
+use \OCP\Security\ISecureRandom;
+
+class ResetExpiredPasswordsJob extends TimedJob {


you can ignore these warnings, we'll need to fix the base class

Hmm I've a general remark about the necessity of this background job:

I've created another branch (https://github.com/nextcloud/server/commits/enhancement/31005/temporary-passwords-v2), building on this one and adding 2 commits, where password's expiration time is checked in IManager::checkPassword (see 576de4b) hence making this background job unnecessary anymore.

I believe it's a better solution than this background job. Could you please have a look and take a stand?

@StCyr yes, let's use your approach without the background job which checks on-demand

on-demand check implemented (via 71ae5a0 , 9ef1c59, and 63d478b), together with configurable password expiration time

PVince81 · 2022-03-01T09:47:08Z

apps/files_sharing/lib/BackgroundJob/ResetExpiredPasswordsJob.php

+		$qb = $this->connection->getQueryBuilder();
+
+		// QUESTION: DOES THE DATETIME COMPARAISON WORK WELL WHEN TIMEZONES ENTER THE GAME?
+		// I THINK SO, BECAUSE EVERYTHING HAPPENS ON THE SERVER, HENCE ON THE SAME TZ


usually the timezone of server is supposed to be UTC, so should be fine

please remove the comment from the code when ready 😄

Well, the background job idea is discarded => #31220 (comment)

apps/files_sharing/lib/Controller/ShareController.php

PVince81 · 2022-03-01T09:51:48Z

BUG: enter key not working when entering email address to request from

Fixed in 592a1ad.

I'm not very fond of this fix -I find it a bit ugly- but it works; I've tried to create a new route to implement this 2-steps authentication (/s/{token}/authenticate/{redirect} for the password prompt and /s/{token}/identify/{redirect} for the identity/email prompt) but redirection made things difficult and I gave up.

PVince81 · 2022-03-01T09:55:30Z

BUG: need to clear the (public) session info as soon as opening the "request password" page

Steps:

Share a folder with user "another@example.com"
Set a password "test"
Open the email
Open the link
Enter the password "test" => this authenticates you for the link
Open the link again
Click "request access"
Enter email address

Expected result: receive email with new password
Actual result: no email and the share folder appears directly, because of the previous session data

========================

I'm sorry I can't reproduce the bug: If I follow the steps precisely, I'm getting automatically authenticated at step 7, rather than being presented with the 'authenticate' page and the "request password" button. So I can't proceed with step 8 and get your actual result.

This looks like a normal behaviour to me: After being authenticated for the link (at step 5), I receive a session token which remains valid for some time. So, it's normal that I'm getting automatically authenticated the second time I open the link, isn't?

===

Vincent: also cannot reproduce any more in 24.0.0, probably it was fixed through a recent change

apps/files_sharing/lib/Controller/ShareController.php

PVince81 · 2022-03-01T14:20:29Z

core/js/publicshareauth.js

+	emailPrompt.style.display="block";
+
+	// Hides password prompt
+	var passwordRequestButton = document.getElementById('request-password-button-not-talk');


s/-not-talk/-by-email/ ? 😄

if you want. But, I believe it's best to keep it technology-agnostic for if later we implement other means to request passwords (eg: by sms)

PVince81

I've added some comments and found some issues, please have a look

PVince81 · 2022-03-01T14:24:51Z

lib/public/Share/IManager.php

 	 * @return IShare The share object
 	 * @throws \InvalidArgumentException
 	 * @since 9.0.0
 	 */
-	public function updateShare(IShare $share);
+	public function updateShare(IShare $share, bool $sendPassword = false);


this will likely break implementations and might need a new version of the interface

wondering if there's another way by having or deriving this info from the IShare object directly

before adding a new interface let's check if there are really more implementations of IManager or just one

might be ok, see #31447

Hmmm.... Anyway, I'm wondering if this new feature (ie: not sending a temporary password upon public authenticate share creation) is really needed... Eventually, it's not that much of an issue if a temporary password is sent to the recipient upon share creation, rather than waiting for the recipient to explicitely requesting it.

I'm thinking about reverting this change. What's your opinion?

there are scenarios where one might want to manually set a specific password to make it easier for the other person to type (or it's something they gave them already on paper or another medium), so we should allow for still supporting such scenarios

now, I'm not sure if this applies to this piece of code specifically ?

hi Cyrille, you're right about misalignment, thanks for spotting

I'll get this clarified internally as this would be a change of behavior

Hey @StCyr, after a bit of thoughts, we decided we would need a config switch.
Old behaviour would be off by default. :)

Hey @StCyr, after a bit of thoughts, we decided we would need a config switch. Old behaviour would be off by default. :)

A new checkbox in the share menu?

rather a config switch in config.php to switch it globally

implemented in c9940b1

I believe the PR is feature complete now. Do you want me to rebase and squash it?

lib/public/Share/IManager.php

PVince81 · 2022-03-02T16:09:36Z

apps/files_sharing/lib/Controller/ShareController.php

+	 * @param string $identityToken
+	 * @return bool
+	 */
+	protected function validateIdentity(string $identityToken): bool {


please remove the type hint to allow null

you mean the @return bool?

PVince81 · 2022-04-07T18:28:37Z

ran php:cs, rebuilt assets, merged suggestions from @CarlSchwan

now hoping for green CI

PVince81 · 2022-04-07T18:31:09Z

not that easy

"PHP Fatal error:  Declaration of OC\Share20\Share::setPasswordExpirationTime($passwordExpirationTime = null) must be compatible with OCP\Share\IShare::setPasswordExpirationTime($passwordExpirationTime = null): OCP\Share\IShare in /home/runner/work/server/server/lib/private/Share20/Share.php on line 469"

I'll have a look later

lib/public/Share/IShare.php

lib/public/AppFramework/AuthPublicShareController.php

StCyr · 2022-04-09T20:24:17Z

Hi @PVince81 @CarlSchwan,

I've fixed the unit tests (and added a new one to validate that password is not sent via email when temporary passwords are enabled).

Also, the test testCreateSendPasswordByTalkWithEnforcedPasswordProtection was failing because of an unexpected functional change imho. So, I've updated the function ShareByMailProvider::create() to allow sending password to the share owner in that case.

PVince81 · 2022-04-11T14:50:54Z

@StCyr thanks a lot!

apps/files_sharing/lib/Controller/ShareAPIController.php

…age for shares of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves. - Creates a migration step for the files_sharing app to add the 'password_expiration_time' attribute to the oc_shares table. - Makes share temporary passwords' expiration time configurable via a system value. - Adds a system config value to allow permanent share passwords -Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue See #31005 Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>

PVince81

👍

PVince81 · 2022-04-12T07:46:27Z

failing test unrelated and has just been fixed on master

merging

welcome · 2022-04-12T07:46:34Z

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

PVince81 · 2022-04-12T20:34:41Z

seems a bug has sneaked in, the expiration date column never changes for me on master, raised here: #31951

PVince81 · 2022-04-12T20:39:24Z

and some UX feedback: #31952

StCyr requested review from nickvergessen, jospoortvliet, ChristophWurst, usselite and skjnldsv February 16, 2022 17:36

StCyr self-assigned this Feb 16, 2022

nickvergessen reviewed Feb 16, 2022

View reviewed changes

apps/files_sharing/lib/BackgroundJob/ResetExpiredPasswordsJob.php Outdated Show resolved Hide resolved

nickvergessen removed the request for review from jospoortvliet February 18, 2022 09:35

StCyr requested a review from nickvergessen February 21, 2022 08:16

szaimen added this to the Nextcloud 24 milestone Feb 21, 2022

szaimen added 3. to review Waiting for reviews enhancement feature: sharing labels Feb 21, 2022

PVince81 requested review from Pytal, artonge and CarlSchwan February 28, 2022 10:45

PVince81 reviewed Mar 1, 2022

View reviewed changes

apps/files_sharing/lib/Controller/ShareController.php Outdated Show resolved Hide resolved

PVince81 reviewed Mar 1, 2022

View reviewed changes

apps/files_sharing/lib/Controller/ShareController.php Outdated Show resolved Hide resolved

come-nc reviewed Mar 1, 2022

View reviewed changes

apps/files_sharing/lib/Controller/ShareController.php Outdated Show resolved Hide resolved

PVince81 reviewed Mar 1, 2022

View reviewed changes

apps/files_sharing/lib/Controller/ShareController.php Outdated Show resolved Hide resolved

PVince81 reviewed Mar 1, 2022

View reviewed changes

nickvergessen removed their request for review March 1, 2022 14:25

PVince81 requested changes Mar 1, 2022

View reviewed changes

PVince81 reviewed Mar 2, 2022

View reviewed changes

skjnldsv removed the 3. to review Waiting for reviews label Mar 2, 2022

PVince81 force-pushed the enhancement/31005/temporary-passwords branch from 1ae14b4 to 70e790c Compare April 7, 2022 18:25

CarlSchwan reviewed Apr 7, 2022

View reviewed changes

lib/public/Share/IShare.php Outdated Show resolved Hide resolved

CarlSchwan reviewed Apr 7, 2022

View reviewed changes

lib/public/Share/IShare.php Outdated Show resolved Hide resolved

CarlSchwan reviewed Apr 7, 2022

View reviewed changes

lib/public/Share/IShare.php Show resolved Hide resolved

lib/public/Share/IShare.php Show resolved Hide resolved

lib/public/AppFramework/AuthPublicShareController.php Outdated Show resolved Hide resolved

PVince81 assigned CarlSchwan Apr 7, 2022

CarlSchwan force-pushed the enhancement/31005/temporary-passwords branch 5 times, most recently from fd1b563 to 94c8c50 Compare April 8, 2022 11:17

StCyr force-pushed the enhancement/31005/temporary-passwords branch 3 times, most recently from 71391aa to 2aa9885 Compare April 9, 2022 19:10

CarlSchwan approved these changes Apr 11, 2022

View reviewed changes

apps/files_sharing/lib/Controller/ShareAPIController.php Show resolved Hide resolved

StCyr force-pushed the enhancement/31005/temporary-passwords branch from f4abed9 to c6a5c07 Compare April 11, 2022 20:05

PVince81 approved these changes Apr 12, 2022

View reviewed changes

PVince81 merged commit 483741f into master Apr 12, 2022

PVince81 deleted the enhancement/31005/temporary-passwords branch April 12, 2022 07:46

PVince81 mentioned this pull request Apr 12, 2022

[Bug]: Share by mail password expiration not changing after requesting password #31951

Closed

8 tasks

blizzz mentioned this pull request Apr 13, 2022

24.0.0 RC1 #31962

Merged

StCyr mentioned this pull request May 10, 2022

Temporary passwords for protected non-anonymous shares #31005

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient). #31220

Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient). #31220

StCyr commented Feb 16, 2022 •

edited

Loading

PVince81 commented Mar 1, 2022 •

edited by StCyr

Loading

PVince81 Mar 1, 2022

StCyr Mar 1, 2022

PVince81 Mar 2, 2022

StCyr Mar 6, 2022 •

edited

Loading

PVince81 Mar 1, 2022

PVince81 Mar 2, 2022

StCyr Mar 6, 2022

PVince81 commented Mar 1, 2022 •

edited by StCyr

Loading

PVince81 commented Mar 1, 2022 •

edited

Loading

PVince81 Mar 1, 2022

StCyr Mar 1, 2022

PVince81 left a comment

PVince81 Mar 1, 2022

PVince81 Mar 1, 2022

PVince81 Mar 4, 2022

StCyr Mar 6, 2022

PVince81 Mar 7, 2022

PVince81 Mar 14, 2022

skjnldsv Mar 17, 2022

StCyr Mar 18, 2022

PVince81 Mar 22, 2022

StCyr Mar 23, 2022

PVince81 Mar 2, 2022

StCyr Mar 9, 2022

PVince81 commented Apr 7, 2022

PVince81 commented Apr 7, 2022

StCyr commented Apr 9, 2022

PVince81 commented Apr 11, 2022

PVince81 left a comment

PVince81 commented Apr 12, 2022

welcome bot commented Apr 12, 2022

PVince81 commented Apr 12, 2022

PVince81 commented Apr 12, 2022

Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient). #31220

Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient). #31220

Conversation

StCyr commented Feb 16, 2022 • edited Loading

PVince81 commented Mar 1, 2022 • edited by StCyr Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StCyr Mar 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 commented Mar 1, 2022 • edited by StCyr Loading

PVince81 commented Mar 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 commented Apr 7, 2022

PVince81 commented Apr 7, 2022

StCyr commented Apr 9, 2022

PVince81 commented Apr 11, 2022

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 commented Apr 12, 2022

welcome bot commented Apr 12, 2022

PVince81 commented Apr 12, 2022

PVince81 commented Apr 12, 2022

StCyr commented Feb 16, 2022 •

edited

Loading

PVince81 commented Mar 1, 2022 •

edited by StCyr

Loading

StCyr Mar 6, 2022 •

edited

Loading

PVince81 commented Mar 1, 2022 •

edited by StCyr

Loading

PVince81 commented Mar 1, 2022 •

edited

Loading