Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix all modals after vue 5.0 #31319

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix all modals after vue 5.0 #31319

merged 1 commit into from
Feb 23, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 22, 2022 •
edited
Loading

Close #31246

Tested:

  • dashboard modal
  • template picker modal
  • new user modal
  • set user status modal

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/31246/fix-modals \
-e VIEWER_BRANCH=master \
-e TEXT_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug 2. developing Work in progress labels Feb 22, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Feb 22, 2022
@szaimen szaimen force-pushed the fix/31246/fix-modals branch from 030a700 to 337ebf1 Compare February 22, 2022 12:10
@szaimen szaimen force-pushed the fix/31246/fix-modals branch 2 times, most recently from 0853e1c to 71d74b9 Compare February 22, 2022 12:53
@szaimen szaimen marked this pull request as ready for review February 22, 2022 13:10
@szaimen szaimen added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Feb 22, 2022
@szaimen szaimen force-pushed the fix/31246/fix-modals branch from c448805 to c2f2493 Compare February 22, 2022 13:14
@szaimen
Copy link
Contributor Author

szaimen commented Feb 22, 2022

/compile amend /

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 22, 2022
@szaimen @nextcloud-command
fix all modals after vue 5.0
1116529 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen requested review from a team and vanpertsch and removed request for a team February 22, 2022 13:44
@szaimen szaimen added design Design, UI, UX, etc. regression labels Feb 23, 2022
@szaimen szaimen requested a review from Pytal February 23, 2022 10:40
@szaimen
Copy link
Contributor Author

szaimen commented Feb 23, 2022

Thanks Carl and Louis! :)

@szaimen
Copy link
Contributor Author

szaimen commented Feb 23, 2022

samba failure unrelated

@szaimen szaimen merged commit 9630d65 into master Feb 23, 2022
@szaimen szaimen deleted the fix/31246/fix-modals branch February 23, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Test all modals with vue 5.0
3 participants
@szaimen @artonge @CarlSchwan