Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark split database configs as sensitive #31328

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Mark split database configs as sensitive #31328

merged 1 commit into from
Feb 23, 2022

Conversation

nickvergessen
Copy link
Member

Follow up to #30973

@nickvergessen
Mark split database configs as sensitive
6302ff0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Feb 23, 2022
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Feb 23, 2022
@nickvergessen nickvergessen requested review from a team, PVince81, skjnldsv and vanpertsch and removed request for a team February 23, 2022 09:32
@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

PVince81
PVince81 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2022
MautkamManjar
MautkamManjar approved these changes Feb 23, 2022
View reviewed changes
Copy link

@MautkamManjar MautkamManjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you guys elaborate it more

@szaimen szaimen merged commit 692da92 into master Feb 23, 2022
@szaimen szaimen deleted the bugfix/noid/mark-split-database-configs-as-sensitive branch February 23, 2022 16:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 23, 2022
Merged
@nickvergessen
Copy link
Member Author

See https://docs.nextcloud.com/server/latest/admin_manual/configuration_database/splitting.html @MautkamManjar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MautkamManjar MautkamManjar MautkamManjar approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @PVince81 @szaimen @MautkamManjar @skjnldsv