Improve performance of external storage config UI #31381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
approved these changes
Mar 1, 2022
artonge
approved these changes
Mar 1, 2022
CarlSchwan
approved these changes
Mar 1, 2022
with 1000 storages, I'm guessing that it's starting to also be a good idea to define this configuration in Ansible or similar. Usually, these are not configured manually or I hope so. |
skjnldsv
added
4. to release
|
jsunit says no |
skjnldsv
added
2. developing
icewind1991
force-pushed
the
external-config-ui-performance
branch
from
a2df79c
to
f546031
Compare
|
fixed jsunit |
icewind1991
added
4. to release
Pytal
approved these changes
Mar 1, 2022
nextcloud-command
force-pushed
the
external-config-ui-performance
branch
from
f546031
to
57558a5
Compare
this prevents repeated reflows Signed-off-by: Robin Appelman <robin@icewind.nl>
…torages Signed-off-by: Robin Appelman <robin@icewind.nl>
nextcloud-command
force-pushed
the
external-config-ui-performance
branch
from
57558a5
to
7933de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greatly improves the performance of the external storage web ui when a large amount of storages are configured.
This takes loading the UI from ~5m to ~10s when having 1000 storages configured.
(long term this needs to be ported to vue but that's for another day)