Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Censor more configs #31390

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Censor more configs #31390

merged 1 commit into from
Mar 2, 2022

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Mar 1, 2022
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Mar 1, 2022
@nickvergessen nickvergessen requested review from PVince81, blizzz, skjnldsv and a team March 1, 2022 20:00
'external' => [
'/^sites$/',
],
'integration_discourse' => [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eneiluj do other integrations have similar things we should not put into the config report?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen Yes => #31449
Thanks for mentioning that.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/more-censor branch from 8c68215 to 1e27aed Compare March 1, 2022 20:08
@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

@nickvergessen nickvergessen requested a review from mejo- March 1, 2022 20:23
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hopefully some day can do this through info.xml

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 2, 2022
@PVince81
Copy link
Member

PVince81 commented Mar 2, 2022

not merging as there's a pending question, up to you

@nickvergessen nickvergessen merged commit 5bc2a6a into master Mar 2, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/more-censor branch March 2, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants