Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct arg to login flow #31592

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add direct arg to login flow #31592

merged 1 commit into from
Mar 29, 2022

Conversation

CarlSchwan
Copy link
Member

Signed-off-by: Vincent Petry vincent@nextcloud.com
Co-Authored-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Mar 16, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Mar 16, 2022
@CarlSchwan CarlSchwan self-assigned this Mar 16, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment for consistency

core/templates/loginflow/authpicker.php Outdated Show resolved Hide resolved
@CarlSchwan CarlSchwan force-pushed the fix/direct-arg-flow-v2 branch 2 times, most recently from 032e55e to d9e1203 Compare March 16, 2022 14:38
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2022
@CarlSchwan
Copy link
Member Author

Tests are failing

@CarlSchwan CarlSchwan added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 25, 2022
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-Authored-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 28, 2022
@PVince81 PVince81 merged commit 576e4e8 into master Mar 29, 2022
@PVince81 PVince81 deleted the fix/direct-arg-flow-v2 branch March 29, 2022 16:21
@PVince81
Copy link
Member

/backport to stable23

@PVince81
Copy link
Member

/backport to stable22

<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
<input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" />
<input type="hidden" name="oauthState" value="<?php p($_['oauthState']) ?>" />
<?php if (p($_['direct'])) { ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helloooo :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress 4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants