Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shared mount roots not being returned from getSharesInFolder #31610

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

icewind1991
Copy link
Member

Mountpoints currently aren't shown due to the f.parent filter

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 17, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Mar 17, 2022
@szaimen szaimen requested review from a team and skjnldsv and removed request for a team March 23, 2022 11:44
@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2022

/backport to stable23

@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2022

/backport to stable22

@szaimen szaimen added the bug label Mar 23, 2022
@szaimen szaimen requested a review from nickvergessen March 23, 2022 11:51
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the shares-in-folder-mounts branch from b140451 to e83ad8c Compare March 31, 2022 15:26
@blizzz blizzz mentioned this pull request Apr 7, 2022
@szaimen szaimen requested review from PVince81 and blizzz April 7, 2022 15:06
@PVince81
Copy link
Member

@artonge this will obsolete part of #31728

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm just a bit worried of side effects

@PVince81
Copy link
Member

hmm, besides https://github.com/nextcloud/server/blob/master/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L146 and #31728 I didn't find any other usage for this, so should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants